[lttng-dev] [PATCH lttng-modules] Fix: Use generic irqs_disabled_flags

Mathieu Desnoyers mathieu.desnoyers at efficios.com
Thu Dec 10 07:56:31 EST 2015


----- On Dec 9, 2015, at 5:25 PM, Michael Jeanson mjeanson at efficios.com wrote:

> instead of arch_irqs_disabled_flags, this fixes the build for kernel < 2.6.37
> 
> See linux commit df9ee29270c11dba7d0fe0b83ce47a4d8e8d2101 for more details.
> 
> Signed-off-by: Michael Jeanson <mjeanson at efficios.com>
> ---
> wrapper/irqflags.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/wrapper/irqflags.h b/wrapper/irqflags.h
> index 77f8382..74c340b 100644
> --- a/wrapper/irqflags.h
> +++ b/wrapper/irqflags.h
> @@ -33,7 +33,7 @@ int lttng_regs_irqs_disabled(struct pt_regs *regs)
> {
> 	unsigned long flags = regs->flags;
> 
> -	return arch_irqs_disabled_flags(flags);
> +	return irqs_disabled_flags(flags);

Can you try with raw_irqs_disabled_flags(flags) instead ?

The non-raw version comes with tracing, and I don't want to invoke
tracing from within the tracer, which could cause infinite recursion
if this instrumentation gets enabled.

Thanks,

Mathieu

> }
> 
> #else
> --
> 1.9.1

-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com



More information about the lttng-dev mailing list