[lttng-dev] [PATCH lttng-modules v3 1/3] Do not override the pipe syscall on MIPS.

[Mathieu Desnoyers]

----- On Jul 29, 2015, at 6:04 AM, Lars Persson lars.persson at axis.com wrote:

> MIPS has a non-standard calling convention for pipe.
> 
> Signed-off-by: Lars Persson <larper at axis.com>
> ---
> instrumentation/syscalls/headers/syscalls_pointers_override.h | 2 ++
> 1 file changed, 2 insertions(+)
> 
> diff --git a/instrumentation/syscalls/headers/syscalls_pointers_override.h
> b/instrumentation/syscalls/headers/syscalls_pointers_override.h
> index a552908..85cb2e8 100644
> --- a/instrumentation/syscalls/headers/syscalls_pointers_override.h
> +++ b/instrumentation/syscalls/headers/syscalls_pointers_override.h
> @@ -41,6 +41,7 @@ SC_LTTNG_TRACEPOINT_EVENT(getcpu,
> 	)
> )
> 
> +#ifndef CONFIG_CPU_MIPS32
> #define OVERRIDE_32_pipe
> #define OVERRIDE_64_pipe
> SC_LTTNG_TRACEPOINT_EVENT(pipe,
> @@ -50,6 +51,7 @@ SC_LTTNG_TRACEPOINT_EVENT(pipe,
> 		sc_out(ctf_user_array(int, fildes, fildes, 2))
> 	)
> )
> +#endif

Instead of multiplying the number of ifdefs for each architecture
in the generic file, we instead move the pipe definition to arch-specific
files ?

Thanks,

Mathieu

> 
> #define OVERRIDE_32_pipe2
> #define OVERRIDE_64_pipe2
> --
> 2.1.4
> 
> 
> _______________________________________________
> lttng-dev mailing list
> lttng-dev at lists.lttng.org
> http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com