[lttng-dev] [BABELTRACE stable-1.2 PATCH] Hide the packet_seq_num field

[Julien Desfossez]

On 15-08-03 11:41 AM, Mathieu Desnoyers wrote:
> Acked-by: Mathieu Desnoyers <mathieu.desnoyers at efficios.com>
> 
> Could we backport it to current babeltrace stable releases too ?
This patch is already meant for babeltrace stable-1.2 branch and it
should apply nicely on master as well.

I think we should merge it soon since the new field is already produced
by lttng-modules master and will probably start confusing the users who
automatically parse the ctf-text output (we have all done it ;-) ).

Thanks,

Julien

> 
> Thanks,
> 
> Mathieu
> 
> ----- On Aug 3, 2015, at 11:35 AM, Julien Desfossez jdesfossez at efficios.com wrote:
> 
>> The packet_seq_num is a new field in LTTng 2.8 that should be hidden
>> from the ctf-text output as it is not really relevant for the users of
>> the text output.
>>
>> Signed-off-by: Julien Desfossez <jdesfossez at efficios.com>
>> ---
>> formats/ctf-text/ctf-text.c | 6 +++++-
>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/formats/ctf-text/ctf-text.c b/formats/ctf-text/ctf-text.c
>> index 9d5123a..2ba0823 100644
>> --- a/formats/ctf-text/ctf-text.c
>> +++ b/formats/ctf-text/ctf-text.c
>> @@ -115,7 +115,8 @@ static GQuark Q_STREAM_PACKET_CONTEXT_TIMESTAMP_BEGIN,
>> 	Q_STREAM_PACKET_CONTEXT_TIMESTAMP_END,
>> 	Q_STREAM_PACKET_CONTEXT_EVENTS_DISCARDED,
>> 	Q_STREAM_PACKET_CONTEXT_CONTENT_SIZE,
>> -	Q_STREAM_PACKET_CONTEXT_PACKET_SIZE;
>> +	Q_STREAM_PACKET_CONTEXT_PACKET_SIZE,
>> +	Q_STREAM_PACKET_CONTEXT_PACKET_SEQ_NUM;
>>
>> static
>> void __attribute__((constructor)) init_quarks(void)
>> @@ -125,6 +126,7 @@ void __attribute__((constructor)) init_quarks(void)
>> 	Q_STREAM_PACKET_CONTEXT_EVENTS_DISCARDED =
>> 	g_quark_from_static_string("stream.packet.context.events_discarded");
>> 	Q_STREAM_PACKET_CONTEXT_CONTENT_SIZE =
>> 	g_quark_from_static_string("stream.packet.context.content_size");
>> 	Q_STREAM_PACKET_CONTEXT_PACKET_SIZE =
>> 	g_quark_from_static_string("stream.packet.context.packet_size");
>> +	Q_STREAM_PACKET_CONTEXT_PACKET_SEQ_NUM =
>> g_quark_from_static_string("stream.packet.context.packet_seq_num");
>> }
>>
>> static
>> @@ -152,6 +154,8 @@ int print_field(struct bt_definition *definition)
>> 		return 0;
>> 	if (definition->path == Q_STREAM_PACKET_CONTEXT_PACKET_SIZE)
>> 		return 0;
>> +	if (definition->path == Q_STREAM_PACKET_CONTEXT_PACKET_SEQ_NUM)
>> +		return 0;
>>
>> 	return 1;
>> }
>> --
>> 1.9.1
>