[lttng-dev] lttng-modules: close on exec warning with 3.2.x kernels

[Mathieu Desnoyers]

Hi Julien,

Can you investigate ? It happens when building lttng-modules
master against a v3.2.62 Linux kernel.

In file included from include/linux/bitops.h:22:0,
                 from include/linux/kernel.h:17,
                 from include/linux/cache.h:4,
                 from include/linux/time.h:7,
                 from include/linux/stat.h:60,
                 from include/linux/module.h:10,
                 from /home/compudj/git/lttng-modules/lttng-statedump-impl.c:30:
/home/compudj/git/lttng-modules/lttng-statedump-impl.c: In function ‘lttng_dump_one_fd’:
/home/compudj/git/linux/arch/x86/include/asm/bitops.h:338:29: warning: passing argument 2 of ‘constant_test_bit’ from incompatible pointer type
   ? constant_test_bit((nr), (addr)) \
                             ^
/home/compudj/git/lttng-modules/lttng-statedump-impl.c:240:27: note: in expansion of macro ‘test_bit’
  if (fd < fdt->max_fds && test_bit(fd, fdt->close_on_exec))
                           ^
/home/compudj/git/linux/arch/x86/include/asm/bitops.h:309:28: note: expected ‘const volatile long unsigned int *’ but argument is of type ‘struct fd_set *’
 static __always_inline int constant_test_bit(unsigned int nr, const volatile unsigned long *addr)
                            ^
/home/compudj/git/linux/arch/x86/include/asm/bitops.h:339:29: warning: passing argument 2 of ‘variable_test_bit’ from incompatible pointer type
   : variable_test_bit((nr), (addr)))
                             ^
/home/compudj/git/lttng-modules/lttng-statedump-impl.c:240:27: note: in expansion of macro ‘test_bit’
  if (fd < fdt->max_fds && test_bit(fd, fdt->close_on_exec))
                           ^
/home/compudj/git/linux/arch/x86/include/asm/bitops.h:315:19: note: expected ‘const volatile long unsigned int *’ but argument is of type ‘struct fd_set *’
 static inline int variable_test_bit(int nr, volatile const unsigned long *addr)
                   ^

Thanks,

Mathieu


-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com