[lttng-dev] [PATCH lttng-tools v3 0/4] Dynamic probe list support

David Goulet dgoulet at efficios.com
Wed May 14 16:47:30 EDT 2014


Merged!

I merged it with some minor syntax fixes mostly in modprobe.c. There is
one thing I don't accept at all is if/else without {}. Remember the goto
fail; bug :).

Anyhow, I fixed them to fit my OCD if/else issue. ;)

Big thanks for that, this is really great! I would love to improve that
with support in the "lttng" command line that could take a list and
spawn the sessiond with it. Also, the configuration file coming in 2.5
(currently in master).

Cheers!
David

On 14 May (16:26:28), Jan Glauber wrote:
> Hi David,
> 
> here are the rebased patches (onto 88564da). There are no functional
> changes to the previous version.
> 
> Jan Glauber (4):
>   Use common functions for module loading and unloading
>   Seperate probe modules from control modules
>   Remove required parameter from module parameters
>   Configurable kernel module probes support
> 
>  doc/man/lttng-sessiond.8              |    7 +
>  src/bin/lttng-sessiond/kern-modules.h |    3 +-
>  src/bin/lttng-sessiond/main.c         |    5 +
>  src/bin/lttng-sessiond/modprobe.c     |  307 ++++++++++++++++++---------------
>  src/bin/lttng-sessiond/modprobe.h     |    2 +
>  src/common/defaults.h                 |    3 +
>  src/common/utils.c                    |   10 ++
>  src/common/utils.h                    |    1 +
>  8 files changed, 200 insertions(+), 138 deletions(-)
> 
> -- 
> 1.7.9.5
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 603 bytes
Desc: Digital signature
URL: <http://lists.lttng.org/pipermail/lttng-dev/attachments/20140514/087efc44/attachment-0001.sig>


More information about the lttng-dev mailing list