[lttng-dev] Toxic comments in lttng-sessiond main.c

[Thibault, Daniel]

(for version 2.3)
/usr/src/lttng-tools/src/bin/lttng-sessiond/main.c (3613..3648):

static void *thread_manage_clients(void *data)
{
[...]
	DBG("[thread] Manage client started");
[...]
	ret = lttcomm_listen_unix_sock(client_sock);
[...]
	/* Add the application registration socket */
	ret = lttng_poll_add(&events, client_sock, LPOLLIN | LPOLLPRI);

   Shouldn't that last comment read "/* Add the client socket */"?

   A little later, lines 3700..3701:

			/* Event on the registration socket */
			if (pollfd == client_sock) {

   Shouldn't that comment read "/* Event on the client socket */"?

   Similar copy-and-paste errors appear in one other thread routine: thread_manage_health (lines 3453 and 3489).  The others (including the two exiled to ust-thread.c and ht-cleanup.c) appear OK.

Daniel U. Thibault
Protection des systèmes et contremesures (PSC) | Systems Protection & Countermeasures (SPC)
Cyber sécurité pour les missions essentielles (CME) | Mission Critical Cyber Security (MCCS)
R & D pour la défense Canada - Valcartier (RDDC Valcartier) | Defence R&D Canada - Valcartier (DRDC Valcartier)
2459 route de la Bravoure
Québec QC  G3J 1X5
CANADA
Vox : (418) 844-4000 x4245
Fax : (418) 844-4538
NAC : 918V QSDJ <http://www.travelgis.com/map.asp?addr=918V%20QSDJ>
Gouvernement du Canada | Government of Canada
<http://www.valcartier.drdc-rddc.gc.ca/>