[lttng-dev] [PATCH urcu] x86: drop extra semi-colon in caa_cpu_relax

Mathieu Desnoyers mathieu.desnoyers at efficios.com
Thu Jul 31 15:59:33 EDT 2014


----- Original Message -----
> From: "Eric Wong" <normalperson at yhbt.net>
> To: "Mathieu Desnoyers" <mathieu.desnoyers at efficios.com>
> Cc: lttng-dev at lists.lttng.org
> Sent: Wednesday, July 30, 2014 8:21:51 PM
> Subject: [PATCH urcu] x86: drop extra semi-colon in caa_cpu_relax
> 
> This fixes compilation in braceless if/else constructs:
> 
> 	if (expr)
> 		caa_cpu_relax();
> 	else
> 		...
> 
> Signed-off-by: Eric Wong <normalperson at yhbt.net>
> ---
>   Btw, did you notice my rculfhash patches last month.
>   I just realize I forgot to Cc you directly.
>   Thanks for URCU!

Hi Eric,

Patch merged, thanks!

Yes, I've seen them in my inbox, but was unfortunately
very busy at the time. Thanks for the reminder!

Mathieu


> 
>  urcu/arch/x86.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/urcu/arch/x86.h b/urcu/arch/x86.h
> index 7af1ca5..ccc4ce8 100644
> --- a/urcu/arch/x86.h
> +++ b/urcu/arch/x86.h
> @@ -66,7 +66,7 @@ extern "C" {
>  #endif
>  #endif
>  
> -#define caa_cpu_relax()	__asm__ __volatile__ ("rep; nop" : : : "memory");
> +#define caa_cpu_relax()	__asm__ __volatile__ ("rep; nop" : : : "memory")
>  
>  #define rdtscll(val)							  \
>  	do {						  		  \
> --
> EW
> 

-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com



More information about the lttng-dev mailing list