[lttng-dev] Ping: Re: [PATCH lttng-ust] Bugfix for http://bugs.lttng.org/issues/745

[Woegerer, Paul]

Hi Mathieu,

Since we have no other options currently (see LD_AUDIT discussion) we
really should get this merged into master. As said, it's thoroughly
tested and should not cause any ill side-effects.

Many Thanks,
Paul

On 07/04/2014 02:21 PM, Paul Woegerer wrote:
> Since (at least) in the short term LD_AUDIT will not be able to make sem_wait()
> in the static constructor go away I provide the following patch to fix
> http://bugs.lttng.org/issues/745.
> 
> It works by making the process of forking mutual exclusive with base address
> statedumping that happens from the ust_listener_thread.
> 
> I have tested this fix with several variations of (constrained) fork bombs
> (including tests/regression/ust/daemon from lttng-tools) on x86_64, ARM(imx6q)
> and powerpc(P4080DS). It works reliable. I could not find any issues with this
> approach.
> 
> Paul Woegerer (1):
>   Bugfix for #745 deadlock with baddr statedump+fork
> 
>  liblttng-ust/lttng-ust-comm.c | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
> 


-- 
Paul Woegerer, SW Development Engineer
Sourcery Analyzer <http://go.mentor.com/sourceryanalyzer>
Mentor Graphics, Embedded Software Division