[lttng-dev] [RFC Patch Tools 2/4] Seperate probe modules from control modules

Jan Glauber jan.glauber at gmail.com
Thu Apr 3 06:57:45 EDT 2014


Move all control modules to the control list and make a seperate
probes list.

Signed-off-by: Jan Glauber <jan.glauber at gmail.com>
---
 src/bin/lttng-sessiond/modprobe.c |   24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/src/bin/lttng-sessiond/modprobe.c b/src/bin/lttng-sessiond/modprobe.c
index b84c07e..ea3fb39 100644
--- a/src/bin/lttng-sessiond/modprobe.c
+++ b/src/bin/lttng-sessiond/modprobe.c
@@ -25,16 +25,9 @@
 #include "modprobe.h"
 #include "kern-modules.h"
 
-/* MUST be loaded first */
+/* LTTng kernel tracer base modules list */
 const struct kern_modules_param kern_modules_control[] = {
-	{ "lttng-tracer", 1 },
-};
-
-/* LTTng kernel tracer modules list */
-const struct kern_modules_param kern_modules_list[] = {
-	{ "lttng-ftrace", 0 },
-	{ "lttng-kprobes", 0 },
-	{ "lttng-kretprobes", 0 },
+	{ "lttng-tracer", 1 },	/* MUST be loaded first so keep at top */
 	{ "lttng-lib-ring-buffer", 1 },
 	{ "lttng-ring-buffer-client-discard", 1 },
 	{ "lttng-ring-buffer-client-overwrite", 1 },
@@ -43,6 +36,13 @@ const struct kern_modules_param kern_modules_list[] = {
 	{ "lttng-ring-buffer-client-mmap-overwrite", 1 },
 	{ "lttng-ring-buffer-metadata-mmap-client", 1 },
 	{ "lttng-types", 0 },
+	{ "lttng-ftrace", 0 },
+	{ "lttng-kprobes", 0 },
+	{ "lttng-kretprobes", 0 },
+};
+
+/* LTTng kernel tracer probe modules list */
+const struct kern_modules_param kern_modules_probes[] = {
 	{ "lttng-probe-asoc", 0 },
 	{ "lttng-probe-block", 0 },
 	{ "lttng-probe-btrfs", 0 },
@@ -130,7 +130,7 @@ void modprobe_remove_lttng_control(void)
  */
 void modprobe_remove_lttng_data(void)
 {
-	return modprobe_remove_lttng(kern_modules_list,
+	return modprobe_remove_lttng(kern_modules_probes,
 				     ARRAY_SIZE(kern_modules_list));
 }
 
@@ -188,6 +188,6 @@ int modprobe_lttng_control(void)
  */
 int modprobe_lttng_data(void)
 {
-	return modprobe_lttng(kern_modules_list,
-			      ARRAY_SIZE(kern_modules_list));
+	return modprobe_lttng(kern_modules_probes,
+			      ARRAY_SIZE(kern_modules_probes));
 }
-- 
1.7.9.5




More information about the lttng-dev mailing list