[lttng-dev] [PATCH userspace-rcu] use a filled signal mask to disable all signals

[Mathieu Desnoyers]

* Brosseau, Yannick (yannick.brosseau at gmail.com) wrote:
> On Fri, May 10, 2013 at 7:38 AM, Mathieu Desnoyers <
> mathieu.desnoyers at efficios.com> wrote:
> 
> > Hi Dave,
> >
> > Nice catch ! I've reworked the patch to also fix compat_arch_x86.c and
> > use SIG_BLOCK at those sites (details in changelog). Here is the version
> > I plan to merge into userspace rcu. Thanks for spotting this!
> >
> > Mathieu
> >
> > commit 6ed4b2e64c6cef5d6d1a1c1943f29dbf4edf026a
> > Author: Mathieu Desnoyers <mathieu.desnoyers at efficios.com>
> > Date:   Fri May 10 07:30:18 2013 -0400
> >     Updates by Mathieu Desnoyers:
> >
> >     - Use SIG_BLOCK instead of SIG_SETMASK when setting a filled mask. This
> >       has the same behavior in this case (since we're blocking all
> > signals),
> >       but is semantically neater: if we ever some signals from that mask,
> >
> 
> if we ever what? Looks like a missing word in this changelog.

remove. sorry, it will stay like this.

Thanks,

Mathieu

> 
> 
> >       we'd like to to a union with the signal mask already blocked by the
> >       application.
> >     - Also fix incorrect signal masking in compat_arch_x86.c.
> >
> >     Reported-by: David Pelton <dpelton at ciena.com>
> >     Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers at efficios.com>

-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com