[lttng-dev] [LTTNG-TOOLS PATCH] UST periodical metadata flush

[Thibault, Daniel]

-----Message d'origine-----
Date: Mon, 25 Mar 2013 22:27:05 -0400
From: Julien Desfossez <jdesfossez at efficios.com>

diff --git a/src/bin/lttng-consumerd/lttng-consumerd.c b/src/bin/lttng-consumerd/lttng-consumerd.c
index 8486807..afac445 100644
--- a/src/bin/lttng-consumerd/lttng-consumerd.c
+++ b/src/bin/lttng-consumerd/lttng-consumerd.c
[...]
@@ -138,6 +140,8 @@ static void usage(FILE *fp)
 			"Specify path for the command socket\n");
 	fprintf(fp, "  -e, --consumerd-err-sock PATH     "
 			"Specify path for the error socket\n");
+	fprintf(fp, "  -e, --consumerd-metadata-sock PATH     "
+			"Specify path for the metadata socket (UST only)\n");
 	fprintf(fp, "  -d, --daemonize                    "
 			"Start as a daemon.\n");
 	fprintf(fp, "  -q, --quiet                        "
[...]
@@ -200,6 +205,9 @@ static void parse_args(int argc, char **argv)
 		case 'e':
 			snprintf(error_sock_path, PATH_MAX, "%s", optarg);
 			break;
+		case 'm':
+			snprintf(metadata_sock_path, PATH_MAX, "%s", optarg);
+			break;
 		case 'd':
 			opt_daemon = 1;
 			break;
+					"--consumerd-metadata-sock", consumer_data->metadata_unix_sock_path,
 					NULL);
 			if (consumerd64_libdir[0] != '\0') {
 				free(tmpnew);
-----Fin du message d'origine-----

   Shouldn't the first part be:

+	fprintf(fp, "  -m, --consumerd-metadata-sock PATH     "
+			"Specify path for the metadata socket (UST only)\n");

...so it matches the second part (and doesn't ambiguate itself with with --consumerd-err-sock)?

Daniel U. Thibault
R & D pour la défense Canada - Valcartier (RDDC Valcartier) / Defence R&D Canada - Valcartier (DRDC Valcartier)
Cyber sécurité pour les missions essentielles (CME) / Mission Critical Cyber Security (MCCS)
Protection des systèmes et contremesures (PSC) / Systems Protection & Countermeasures (SPC)
2459 route de la Bravoure
Québec, QC  G3J 1X5
CANADA
Vox : (418) 844-4000 x4245
Fax : (418) 844-4538
NAC : 918V QSDJ <http://www.travelgis.com/map.asp?addr=918V%20QSDJ>
Gouvernement du Canada / Government of Canada
<http://www.valcartier.drdc-rddc.gc.ca/>