[lttng-dev] [lttng-tools PATCH] Add a git version information in LTTng versions compiled from git sources

[Raphaël Beamonte]

On 2013-03-25 10:30, David Goulet wrote:> Hi,
>
> Two things. First, the version.h.tmpl has to be added to EXTRA_DIST in
> include/Makefile.am

Done. And changed the "version.h" to "nodist_*_headers".

> Second thing, on line 86 of lttng.c, *never* *never* *never* pass a
> variable to printf without a format.
>
> fprintf(ofp, lttng_version);
>
> This is a huge vector attack to format strings. Furthermore, outside of
> the git tree, there is a warning:
>
> lttng.c:86:2: warning: zero-length gnu_printf format string
> [-Wformat-zero-length]

My mistake, forgot to correct that... It's ok in the new patch.

Raphaël

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.lttng.org/pipermail/lttng-dev/attachments/20130325/43b0d9d7/attachment.pgp>