[lttng-dev] [PATCH] lttng-abi.c: fix the error check

[maxin.john at enea.com]

From: "Maxin B. John" <maxin.john at enea.com>

lttng_syscalls_register() may return -ENOMEM or -EINVAL. So fix
the error path to check for negative values in lttng_abi_create_event()
and lttng_channel_ioctl().

Signed-off-by: Maxin B. John <maxin.john at enea.com>
---
 lttng-abi.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/lttng-abi.c b/lttng-abi.c
index 25a350a..5613b75 100644
--- a/lttng-abi.c
+++ b/lttng-abi.c
@@ -648,7 +648,7 @@ int lttng_abi_create_event(struct file *channel_file,
 		if (event_param->name[0] != '\0')
 			return -EINVAL;
 		ret = lttng_syscalls_register(channel, NULL);
-		if (ret)
+		if (ret < 0)
 			goto fd_error;
 		event_fd = 0;
 		break;
@@ -753,6 +753,8 @@ long lttng_channel_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
 			break;
 		}
 		ret = lttng_abi_create_event(file, uevent_param);
+		if (ret < 0)
+			return -ENOMEM;
 
 old_event_error_free_old_param:
 		kfree(old_uevent_param);
-- 
1.7.5.4