[lttng-dev] [RFC-PATCH] Adding trap tracepoints definitions

[Mathieu Desnoyers]

* Francis Deslauriers (fdeslaur at gmail.com) wrote:
> This patch adds new trap tracepoint definitions. Both trap entry and trap exit
> tracepoints can be added.

"Both trap entry and trap exit tracepoints can be added."

-> It enables each architecture to add trap instrumentation.

> 
> Signed-off-by: Francis Deslauriers <fdeslaur at gmail.com>
> ---
>  include/trace/events/trap.h |   45 +++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 45 insertions(+)
>  create mode 100644 include/trace/events/trap.h
> 
> diff --git a/include/trace/events/trap.h b/include/trace/events/trap.h
> new file mode 100644
> index 0000000..e1847a3
> --- /dev/null
> +++ b/include/trace/events/trap.h
> @@ -0,0 +1,45 @@
> +#undef TRACE_SYSTEM
> +#define TRACE_SYSTEM trap
> +
> +#if !defined(_TRACE_TRAP_H) || defined(TRACE_HEADER_MULTI_READ)
> +#define _TRACE_TRAP_H
> +
> +#include <linux/tracepoint.h>
> +
> +TRACE_EVENT(trap_entry,
> +
> +	TP_PROTO(struct pt_regs *regs, long trap),
> +
> +	TP_ARGS(regs, trap),
> +
> +	TP_STRUCT__entry(
> +		__field(	long,	trap)

Please make sure "trap" and "ip" are aligned in the source code. This is
the style used by other instrumentation files.

> +		__field(	unsigned long,	ip)
> +	),
> +	TP_fast_assign(
> +		__entry->trap = trap;
> +		__entry->ip = regs ? instruction_pointer(regs) : 0UL;
> +	),
> +
> +	TP_printk("number=%ld, ip = %lu", __entry->trap, __entry->ip)

"number="   "ip = " -> space inconsistency.

> +);
> +
> +TRACE_EVENT(trap_exit,
> +
> +	TP_PROTO(long trap),
> +
> +	TP_ARGS(trap),
> +
> +	TP_STRUCT__entry(
> +		__field(	long,	trap)
> +	),
> +	TP_fast_assign(
> +		__entry->trap = trap;
> +	),
> +
> +	TP_printk("number=%ld", __entry->trap)

space or not around =  ?

Thanks,

Mathieu

> +);
> +
> +#endif /* _TRACE_TRAP_H */
> +/* This part must be outside protection */
> +#include <trace/define_trace.h>
> -- 
> 1.7.10.4
> 
> 
> _______________________________________________
> lttng-dev mailing list
> lttng-dev at lists.lttng.org
> http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com