[lttng-dev] [PATCH] Add a git version information in LTTng versions compiled from git sources

[Raphaël Beamonte]

On 2013-03-14 12:53, David Goulet wrote:
> Another thing, we really do prefer having #ifdef statement in one call
> site per binaries this means that you might want to use like
> "lttng-sessiond.h", put the ifdef there and do an inline function to
> print the correct version.

Ok, no problem ! Will be like that in the next try of the patch.

> Last thing, don't use spaces please! You can use extras/checkpatch.pl to
> make sure you are ok with the std we have.

Sorry, copy/paste mistake. I'll correct that.

On 2013-03-14 13:04, David Goulet wrote:
> Oh wait it did create the version.h with the GIT_VERSION but I had to
> compile again so this header file could be used in the code.

Thanks for reporting that. Didn't see it at first !

On 2013-03-14 13:15, Yannick Brosseau wrote:
> I think this method is really sensible on the execution order of the
> makefile. Maybe it should be put at the top level.

Right, I'll do that.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.lttng.org/pipermail/lttng-dev/attachments/20130314/6fff72e0/attachment.pgp>