[lttng-dev] [PATCH lttng-ust] Add trace instrumentation for some pthread functions.

Jérémie Galarneau jeremie.galarneau at efficios.com
Wed Jul 31 18:00:14 EDT 2013


Hi Stefan,

Please inline your patches in the future as it makes the review process simpler.
There are a number of stylistic problems, mostly misplaced braces.

You can run your patches through the checkpatch.pl script found in
lttng-tools/extras. It will spot most coding-style related problems
right away.

Also, I think lttng-ust-pthread-mutex.c may be a more appropriate name
than pthread.c

Thanks,
Jérémie

On Wed, Jul 31, 2013 at 4:41 PM, Stefan Seefeld
<stefan_seefeld at mentor.com> wrote:
> The attached patch introduces a pthread wrapper library with initial
> instrumentation for pthread_mutex_lock, pthread_mutex_trylock, and
> pthread_mutex_unlock.
> New tracepoints are introduced for each of those. For the lock function,
> two distinct tracepoints are emitted: one before the lock is requested,
> another after it has been acquired.
>
> --
> Stefan Seefeld
> CodeSourcery / Mentor Graphics
> http://www.mentor.com/embedded-software/
>
> _______________________________________________
> lttng-dev mailing list
> lttng-dev at lists.lttng.org
> http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
>



-- 
Jérémie Galarneau
EfficiOS Inc.
http://www.efficios.com



More information about the lttng-dev mailing list