[lttng-dev] [LTTng-tools PATCH] Test for presence of bison and flex when building from git

[Yannick Brosseau]

On 2013-07-17 14:00, Mathieu Desnoyers wrote:
> * Mathieu Desnoyers (mathieu.desnoyers at efficios.com) wrote:
>> * Yannick Brosseau (yannick.brosseau at gmail.com) wrote:
> [...]
>> This test (and the other for filter-lexer.c) is incorrect for VPATH
>> builds.
>>
>> If someone grabs the tarball generated by make dist, extracts it in a
>> "source" directory, and calls configure from a different build
>> directory, this check behaves as if it was a git tree (missing .h/.c
>> files).
> How about this instead ?

I'm not sure if $topdir or $srcdir would be the right one to use, but
yes the idea would work.

> ---
> diff --git a/configure.ac b/configure.ac
> index 9d93791..33c54fc 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -287,7 +287,19 @@ LT_INIT
>  AC_PROG_YACC
>  AC_PROG_LEX
>  
> -AC_DEFUN([AC_PROG_BISON], [AC_CHECK_PROGS(BISON, bison, bison)])
> +if test ! -f "$srcdir/src/lib/lttng-ctl/filter/filter-parser.h"; then
> +	if test x"$YACC" != "xbison -y"; then
> +		AC_MSG_ERROR([[bison not found and is required when building from git.
> +		Please install bison]])
> +	fi
> +fi
> +
> +if test ! -f "$srcdir/src/lib/lttng-ctl/filter/filter-lexer.c"; then
> +	if test x"$LEX" != "xflex"; then
> +		AC_MSG_ERROR([[flex not found and is required when building from git.
> +		Please install flex]])
> +	fi
> +fi
>  
>  CFLAGS="-Wall $CFLAGS -g -fno-strict-aliasing"
>  
>