[lttng-dev] [LTTng-tools PATCH] Test for presence of bison and flex when building from git

[Mathieu Desnoyers]

* Yannick Brosseau (yannick.brosseau at gmail.com) wrote:
> Signed-off-by: Yannick Brosseau <yannick.brosseau at gmail.com>
> ---
>  configure.ac |   14 +++++++++++++-
>  1 file changed, 13 insertions(+), 1 deletion(-)
> 
> diff --git a/configure.ac b/configure.ac
> index b430152..b34e39a 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -287,7 +287,19 @@ LT_INIT
>  AC_PROG_YACC
>  AC_PROG_LEX
>  
> -AC_DEFUN([AC_PROG_BISON], [AC_CHECK_PROGS(BISON, bison, bison)])
> +if test ! -f "src/lib/lttng-ctl/filter/filter-parser.h"; then

This test (and the other for filter-lexer.c) is incorrect for VPATH
builds.

If someone grabs the tarball generated by make dist, extracts it in a
"source" directory, and calls configure from a different build
directory, this check behaves as if it was a git tree (missing .h/.c
files).

Thoughts ?

Thanks,

Mathieu

> +	if test x"$YACC" != "xbison -y"; then
> +		AC_MSG_ERROR([[bison not found and is required when building from git.
> +		Please install bison]])
> +	fi
> +fi
> +
> +if test ! -f "src/lib/lttng-ctl/filter/filter-lexer.c"; then
> +	if test x"$LEX" != "xflex"; then
> +		AC_MSG_ERROR([[flex not found and is required when building from git.
> +		Please install flex]])
> +	fi
> +fi
>  
>  CFLAGS="-Wall $CFLAGS -g -fno-strict-aliasing"
>  
> -- 
> 1.7.10.4
> 
> 
> _______________________________________________
> lttng-dev mailing list
> lttng-dev at lists.lttng.org
> http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com