[lttng-dev] babeltrace omits its closing verbose comment

[Thibault, Daniel]

----------------------------------------------------------------------
Message: 1
Date: Fri, 22 Feb 2013 20:13:15 +0000
From: "Thibault, Daniel" <Daniel.Thibault at drdc-rddc.gc.ca>
Subject: [lttng-dev] babeltrace omits its closing verbose comment

> The verbose output of babeltrace (-v, --verbose) is missing its closing comment.  Looking at babeltrace.c, line 670:
>
> fmt_write->close_trace(td_write);
>
> bt_context_put(ctx);
> printf_verbose("finished converting. Output written to:\n%s\n",
>		opt_output_path ? : "<stdout>");
> goto end;
>
> I suspect that the printf_verbose should be moved to *before* the fmt_write->close_trace.  That way the last comment would be sent to stdout
> (or the user-selected --output, once bug 459 (http://bugs.lttng.org/issues/459) is fixed), right?

   Revisiting this, I see I was wrong in wanting the closing comment pushed to stdout: it correctly belongs on stderr, like the '[verbose]' prologue to the babeltrace conversion.  My mistake was caused by using 'babeltrace sometrace -v &> outputtrace' in order to circumvent the (now fixed) -w bug (I should have used just '>').  This made me miss the distinction between what verbose pushes to stderr vs. what it pushes to stdout (or -w).  Quite correctly, --verbose changes only one thing in the output: it adds the stream.event.header to the event records.

Daniel U. Thibault
R & D pour la défense Canada - Valcartier (RDDC Valcartier) / Defence R&D Canada - Valcartier (DRDC Valcartier)
Cyber sécurité pour les missions essentielles (CME) / Mission Critical Cyber Security (MCCS)
Protection des systèmes et contremesures (PSC) / Systems Protection & Countermeasures (SPC)
2459 route de la Bravoure
Québec, QC  G3J 1X5
CANADA
Vox : (418) 844-4000 x4245
Fax : (418) 844-4538
NAC : 918V QSDJ <http://www.travelgis.com/map.asp?addr=918V%20QSDJ>
Gouvernement du Canada / Government of Canada
<http://www.valcartier.drdc-rddc.gc.ca/>