[lttng-dev] lttng-tools lttng-ctl.c lttng_channel_set_default_attr does not have per-UID as its default

[Thibault, Daniel]

   Since the 8692d4e lttng-tools commit (12 July), the default configuration for user-space channels is per-UID (it would be nice if 'lttng enable-channel --help' said so, by the way).  However, in lttng-tools\src\lib\lttng-ctl\lttng-ctl.c, one can still read:

void lttng_channel_set_default_attr(struct lttng_domain *domain,
		struct lttng_channel_attr *attr)
{
[...]
	switch (domain->type) {
	case LTTNG_DOMAIN_KERNEL:
	 	 [...]
		break;
	case LTTNG_DOMAIN_UST:
		switch (domain->buf_type) {
		case LTTNG_BUFFER_PER_UID:
			[...]
			break;
		case LTTNG_BUFFER_PER_PID:
		default:
			[...]
			break;
		}
	default:
		/* Default behavior: leave set to 0. */
		break;
	}
}

   Surely the LTTNG_BUFFER_PER_UID  and LTTNG_BUFFER_PER_PID case blocks should be switched around?

Daniel U. Thibault
Protection des systèmes et contremesures (PSC) | Systems Protection & Countermeasures (SPC)
Cyber sécurité pour les missions essentielles (CME) | Mission Critical Cyber Security (MCCS)
R & D pour la défense Canada - Valcartier (RDDC Valcartier) | Defence R&D Canada - Valcartier (DRDC Valcartier)
2459 route de la Bravoure
Québec QC  G3J 1X5
CANADA
Vox : (418) 844-4000 x4245
Fax : (418) 844-4538
NAC : 918V QSDJ <http://www.travelgis.com/map.asp?addr=918V%20QSDJ>
Gouvernement du Canada | Government of Canada
<http://www.valcartier.drdc-rddc.gc.ca/>