[lttng-dev] [PATCH lttng-tools] Fix: LTTNG_ERR_NEED_ROOT_SESSIOND error message

[Mathieu Desnoyers]

* Thibault, Daniel (Daniel.Thibault at drdc-rddc.gc.ca) wrote:
> ------------------------------
> Date: Wed,  7 Aug 2013 14:58:05 -0400
> From: J?r?mie Galarneau 	<jeremie.galarneau at efficios.com>
> 
> A root session daemon _and_ "tracing" group user membership are required to trace the kernel.
> 
> ---
>  src/common/error.c | 2 +-
> 
> -	[ ERROR_INDEX(LTTNG_ERR_NEED_ROOT_SESSIOND) ] = "Tracing the kernel requires a root lttng-sessiond daemon or \"tracing\" group user membership",
> +	[ ERROR_INDEX(LTTNG_ERR_NEED_ROOT_SESSIOND) ] = "Tracing the kernel requires a root lttng-sessiond daemon and \"tracing\" group user membership",
> 
>    Unless there's been a change in the code, that is just not true.  You can trace the kernel just fine without 'tracing' group membership, as long as you have sudo privileges (and can thus call 'sudo -H lttng').  The root daemon is necessary either way: the text should just read "Tracing the kernel requires a root lttng-sessiond daemon".

The actual right way to word it would be:

Tracing the kernel requires a root lttng-sessiond daemon, as well as \"tracing\"
group membership or root user ID for the lttng client.

Makes sense ?

Thanks,

Mathieu


> 
> Daniel U. Thibault
> Protection des systèmes et contremesures (PSC) | Systems Protection & Countermeasures (SPC)
> Cyber sécurité pour les missions essentielles (CME) | Mission Critical Cyber Security (MCCS)
> R & D pour la défense Canada - Valcartier (RDDC Valcartier) | Defence R&D Canada - Valcartier (DRDC Valcartier)
> 2459 route de la Bravoure
> Québec QC  G3J 1X5
> CANADA
> Vox : (418) 844-4000 x4245
> Fax : (418) 844-4538
> NAC : 918V QSDJ <http://www.travelgis.com/map.asp?addr=918V%20QSDJ>
> Gouvernement du Canada | Government of Canada
> <http://www.valcartier.drdc-rddc.gc.ca/>
> 
> _______________________________________________
> lttng-dev mailing list
> lttng-dev at lists.lttng.org
> http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com