[lttng-dev] [PATCH lttng-tools] Fix: Possible memory leaks when creating filter IR root node

David Goulet dgoulet at efficios.com
Thu Oct 25 15:56:30 EDT 2012


Merged!

Christian Babeux:
> Signed-off-by: Christian Babeux <christian.babeux at efficios.com>
> ---
>  src/lib/lttng-ctl/filter/filter-visitor-generate-ir.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/lib/lttng-ctl/filter/filter-visitor-generate-ir.c b/src/lib/lttng-ctl/filter/filter-visitor-generate-ir.c
> index eec78fc..84122c9 100644
> --- a/src/lib/lttng-ctl/filter/filter-visitor-generate-ir.c
> +++ b/src/lib/lttng-ctl/filter/filter-visitor-generate-ir.c
> @@ -46,9 +46,11 @@ struct ir_op *make_op_root(struct ir_op *child, enum ir_side side)
>  	case IR_DATA_UNKNOWN:
>  	default:
>  		fprintf(stderr, "[error] Unknown root child data type\n");
> +		free(op);
>  		return NULL;
>  	case IR_DATA_STRING:
>  		fprintf(stderr, "[error] String cannot be root data type\n");
> +		free(op);
>  		return NULL;
>  	case IR_DATA_NUMERIC:
>  	case IR_DATA_FIELD_REF:



More information about the lttng-dev mailing list