[lttng-dev] [urcu commit] Fix TLS detection: test with linker, add --disable-compiler-tls

[Mathieu Desnoyers]

* Marek Vavruša (marek.vavrusa at nic.cz) wrote:
> Nice, I can confirm it compiles on OSX10.8 with default gcc and
> autodisables __thread correctly.
> It also builds with clang, __thread enabled/disabled.

Excellent news!

> For backported 0.7, i think the patch for MAP_ANONYMOUS compatibility needs
> to be backported as well (if it's not already).

If you mean this patch:

commit 0d0cf93f74adf0367b3f9d007351984e91d6e91f
Author: Mathieu Desnoyers <mathieu.desnoyers at efficios.com>
Date:   Sat May 26 11:00:16 2012 -0400

    freebsd 8.2 fix: define MAP_ANONYMOUS for compatibility
    
    Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers at efficios.com>

It was merged between 0.7.2 and 0.7.3, so it's part of both stable-0.7
and master branches.

Hopefully I'm not missing another one.

Thanks!

Mathieu


> Great work, thanks!
> 
> Marek
> 
> On 9 November 2012 03:54, Mathieu Desnoyers
> <mathieu.desnoyers at efficios.com>wrote:
> 
> > The following commit is now in the userspace RCU master branch
> > (backported to stable-0.7 branch too). It should fix TLS detection on
> > both NetBSD <= 5.1, and on Darwin, and adds a --disable-compiler-tls
> > flag to force using the pthread_getspecific fallback.
> >
> >
> > commit 75478b32ffe53b0d8b5e687d9cf7ebdd77a085de
> > Author: Mathieu Desnoyers <mathieu.desnoyers at efficios.com>
> > Date:   Thu Nov 8 21:45:04 2012 -0500
> >
> >     Fix TLS detection: test with linker, add --disable-compiler-tls
> >
> >     NetBSD 5.1 and older, as well as Darwin, succeed to compile code
> >     containing TLS, but cannot link it. Test with linker in addition to
> >     compiler for TLS support.
> >
> >     Also add a --disable-compiler-tls configure option to allow users to
> >     force using the pthread getspecific fall back.
> >
> >     Fixes #288
> >
> >     Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers at efficios.com>
> >
> > Feedback is welcome!
> >
> > Thanks,
> >
> > Mathieu
> >
> > --
> > Mathieu Desnoyers
> > Operating System Efficiency R&D Consultant
> > EfficiOS Inc.
> > http://www.efficios.com
> >

-- 
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com