[lttng-dev] Fix filter: pointer to string, not string, should be on stack -- query

[David Bryant]

Hi Mathieu,

Yes, your commit did the trick! My patched version of easy-ust (that 
passed an lvalue string) compiles and runs correctly.

$ lttng view
Trace directory: /home/dbryant/lttng-traces/sample-20121108-105753

[10:59:16.175851994] (+?.?????????) sample:3213 
sample_component:message: { cpu_id = 0 }, { message = "Hello World" }
[10:59:17.176018865] (+1.000166871) sample:3213 
sample_component:message: { cpu_id = 0 }, { message = "Hello World" }
[10:59:18.176188138] (+1.000169273) sample:3213 
sample_component:message: { cpu_id = 0 }, { message = "Hello World" }

Thanks for your quick response!

Dave

On 08/11/12 05:04, Mathieu Desnoyers wrote:
> Hello !
>
> Please upstream lttng-ust master branch HEAD, which includes this
> commit:
>
> commit c4261b0aecaf281fc1ced4c7af96b1ff6d2600d7
> Author: Mathieu Desnoyers <mathieu.desnoyers at efficios.com>
> Date:   Wed Nov 7 13:24:58 2012 -0500
>
>      Fix: re-allow non-lvalue string, sequence, array parameters
>      
>      Issue introduced by upstream commit:
>      
>        commit 27f4b6094f399f2fe231b58801dce98cbd21baa9
>        Author: Mathieu Desnoyers <mathieu.desnoyers at efficios.com>
>        Date: Tue Sep 4 12:17:07 2012 -0400
>      
>        Fix filter: pointer to string, not string, should be on stack
>      
>        Fixes #329
>      
>      Reported-by: David Bryant <david.bryant at quantum.com>
>      Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers at efficios.com>
>
> Please let me know if it helps,
>
> Thanks,
>
> Mathieu
>

----------------------------------------------------------------------
The information contained in this transmission may be confidential. Any disclosure, copying, or further distribution of confidential information is not permitted unless such privilege is explicitly granted in writing by Quantum. Quantum reserves the right to have electronic communications, including email and attachments, sent across its networks filtered through anti virus and spam software programs and retain such messages in order to comply with applicable data security and retention requirements. Quantum is not responsible for the proper and complete transmission of the substance of this communication or for any delay in its receipt.