[lttng-dev] [PATCH 1/3] Improve delete of configuration

[Yannick Brosseau]

On 2012-05-30 05:10, Francis Giraldeau wrote:
> Le 2012-05-29 20:43, David Goulet a écrit :
> > > + if (!config_exists(config_path)) + goto done;
> >
> > Please add {} even for a one liner if().
>
> I used checkpatch.pl from kernel scripts and the standard there is to
> remove them. I can add them, but then patches will not pass the check.
> IMHO I would follow the kernel style, since this makes easier for
> everyone to check their patches. Or maybe there are options to skip
> on-line-if-brace check? There is "--ignore BRACES" but then errors are
> reported, only the description is not shown. Will wait for your input
> on this.
It's not because it's the kernel style that it's a good style... ;-)

Yannick
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lttng.org/pipermail/lttng-dev/attachments/20120530/eaa1dcd8/attachment.html>