[lttng-dev] [PATCH] For all commands/*.c, add poptFreeContext()

Thibault, Daniel Daniel.Thibault at drdc-rddc.gc.ca
Wed Feb 1 13:34:43 EST 2012


-----Message d'origine-----
De : David Goulet [mailto:dgoulet at efficios.com] 
Envoyé : 1 février 2012 13:07

> Hmmm... this one does not apply and I think it's because some of the previous
> patches you sent were not applied making it a bit out of sync...
>
> You sent a lot of patches ;) and I couldn't commit them all so this can
> happen... sorry.

> > --- a/src/bin/lttng/commands/add_context.c
> > +++ b/src/bin/lttng/commands/add_context.c
> > @@ -531,5 +531,6 @@
> >  		free(type);
> >  	}
> >  
> > +	poptFreeContext(pc);
> >  	return ret;
> >  }

   Understandable.  However, this is such an obvious memory leak, and so easily fixed that I'll do just that: pull the latest head down, and generate a new patch.

Daniel U. Thibault
R & D pour la défense Canada - Valcartier (RDDC Valcartier) / Defence R&D Canada - Valcartier (DRDC Valcartier)
Système de systèmes (SdS) / System of Systems (SoS)
Solutions informatiques et expérimentations (SIE) / Computing Solutions and Experimentations (CSE)
2459 Boul. Pie XI Nord
Québec, QC  G3J 1X5
CANADA
Vox : (418) 844-4000 x4245
Fax : (418) 844-4538
NAC: 918V QSDJ
Gouvernement du Canada / Government of Canada
<http://www.valcartier.drdc-rddc.gc.ca/>



More information about the lttng-dev mailing list