[lttng-dev] [PATCH] bin/lttng/commands: require exactly one of --kernel and --userspace

Thibault, Daniel Daniel.Thibault at drdc-rddc.gc.ca
Wed Feb 1 13:05:34 EST 2012


-----Message d'origine-----
De : David Goulet [mailto:david.goulet at polymtl.ca] 
Envoyé : 1 février 2012 11:52

> > Subject: [PATCH] bin/lttng/commands: require exactly one of --kernel and --userspace
> > 
> > Applies to add_context, calibrate, enable/disable_channels/events;
> > list can have none, one or both.
>
> Quickly looking at this patch. We can't do that because there is 3 other
> possible unsupported domain (see lttng.h). So, this is why I kept the above
> if..else.
>
> For the fprintf saying that -u and -k are mutually exclusive, It's a good idea
> but perhaps adding it at the top as a "notice" ?

   Dang, that's too bad, as having just the two domains simplified things quite a bit.  I'll redo this under the assumption that add_context, calibrate, enable/disable_channels/events require exactly one domain, taken from the set that currently includes just kernel and userspace but will later include more alternatives.

Daniel U. Thibault
R & D pour la défense Canada - Valcartier (RDDC Valcartier) / Defence R&D Canada - Valcartier (DRDC Valcartier)
Système de systèmes (SdS) / System of Systems (SoS)
Solutions informatiques et expérimentations (SIE) / Computing Solutions and Experimentations (CSE)
2459 Boul. Pie XI Nord
Québec, QC  G3J 1X5
CANADA
Vox : (418) 844-4000 x4245
Fax : (418) 844-4538
NAC: 918V QSDJ
Gouvernement du Canada / Government of Canada
<http://www.valcartier.drdc-rddc.gc.ca/>



More information about the lttng-dev mailing list