[lttng-dev] [PATCH] Cleanup: Remove misplaced config.h include

Mathieu Desnoyers mathieu.desnoyers at efficios.com
Tue Aug 7 10:43:18 EDT 2012


config.h should _always_ be included first, before system headers, to
ensure coherent size_t across the file.

We force the config.h inclusion by the compiler, so this is not an issue
(configure.ac: DEFAULT_INCLUDES="-I\$(top_srcdir) -I\$(top_builddir)
-I\$(top_builddir)/src -I\$(top_builddir)/include -include config.h"),
but let's remove this misleading line of code.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers at efficios.com>
---
diff --git a/src/common/hashtable/rculfhash.c b/src/common/hashtable/rculfhash.c
index 776f9f3..423d186 100644
--- a/src/common/hashtable/rculfhash.c
+++ b/src/common/hashtable/rculfhash.c
@@ -157,7 +157,6 @@
 #include <stdint.h>
 #include <string.h>
 
-#include "config.h"
 #include <urcu.h>
 #include <urcu-call-rcu.h>
 #include <urcu/arch.h>

-- 
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com



More information about the lttng-dev mailing list