[lttng-dev] LTTng driver submission for staging (2nd attempt)

Mathieu Desnoyers mathieu.desnoyers at efficios.com
Mon Nov 28 07:42:07 EST 2011


Hi Greg,

This a resend of the LTTng driver patchset for staging. After your
review of the first round, I proceeded to the following modifications:

- Understood that git format-patch must be given the commit prior to the
  first commit to include in the patchset as first commit ID, this
  adding the missing 0001-lttng-lib-lttng-priority-heap.patch. (cause of
  the build failure)
- Added missing (empty) system call instrumentation "override" files,
  that were known to git, but discarded by git format-patch. Made sure
  they appear in the patches as place-holders by adding a comment in
  those files.
- Removed gpl*.txt/lgpl*.txt license files.
- Removed Changelog.
- Added TODO file.
- While going through the TODO, I noticed that I needed to fix the
  syscall TRACE_EVENT generation scripts (along with the headers
  generated) to complete support of 32-bit compat syscalls on x86-64. I
  did these modifications.
- Tested the build on x86-64/x86-32, and run-time tested on x86-32,
  using the patchset rather than the git tree commits to ensure you
  won't run into any issues on your side.

Diffstat:

 drivers/staging/lttng/lib/prio_heap/lttng_prio_heap.c                                                |  207 
 drivers/staging/lttng/lib/prio_heap/lttng_prio_heap.h                                                |  117 
 drivers/staging/lttng/lib/ringbuffer/api.h                                                           |   25 
 drivers/staging/lttng/lib/ringbuffer/backend.h                                                       |  250 +
 drivers/staging/lttng/lib/ringbuffer/backend_internal.h                                              |  449 ++
 drivers/staging/lttng/lib/ringbuffer/backend_types.h                                                 |   80 
 drivers/staging/lttng/lib/ringbuffer/config.h                                                        |  298 +
 drivers/staging/lttng/lib/ringbuffer/frontend.h                                                      |  228 +
 drivers/staging/lttng/lib/ringbuffer/frontend_api.h                                                  |  358 +
 drivers/staging/lttng/lib/ringbuffer/frontend_internal.h                                             |  424 +
 drivers/staging/lttng/lib/ringbuffer/frontend_types.h                                                |  176 
 drivers/staging/lttng/lib/ringbuffer/iterator.h                                                      |   70 
 drivers/staging/lttng/lib/ringbuffer/nohz.h                                                          |   30 
 drivers/staging/lttng/lib/ringbuffer/ring_buffer_backend.c                                           |  854 +++
 drivers/staging/lttng/lib/ringbuffer/ring_buffer_frontend.c                                          | 1721 +++++++
 drivers/staging/lttng/lib/ringbuffer/ring_buffer_iterator.c                                          |  798 +++
 drivers/staging/lttng/lib/ringbuffer/ring_buffer_mmap.c                                              |  115 
 drivers/staging/lttng/lib/ringbuffer/ring_buffer_splice.c                                            |  202 
 drivers/staging/lttng/lib/ringbuffer/ring_buffer_vfs.c                                               |  387 +
 drivers/staging/lttng/lib/ringbuffer/vatomic.h                                                       |   85 
 drivers/staging/lttng/lib/ringbuffer/vfs.h                                                           |   89 
 drivers/staging/lttng/lib/bitfield.h                                                                 |  400 +
 drivers/staging/lttng/lib/bug.h                                                                      |   29 
 drivers/staging/lttng/lib/align.h                                                                    |   61 
 drivers/staging/lttng/lib/Makefile                                                                   |   11 
 drivers/staging/lttng/wrapper/ftrace.h                                                               |   70 
 drivers/staging/lttng/wrapper/inline_memcpy.h                                                        |   11 
 drivers/staging/lttng/wrapper/kallsyms.h                                                             |   28 
 drivers/staging/lttng/wrapper/perf.h                                                                 |   32 
 drivers/staging/lttng/wrapper/poll.h                                                                 |   14 
 drivers/staging/lttng/wrapper/ringbuffer/api.h                                                       |    1 
 drivers/staging/lttng/wrapper/ringbuffer/backend.h                                                   |    1 
 drivers/staging/lttng/wrapper/ringbuffer/backend_internal.h                                          |    2 
 drivers/staging/lttng/wrapper/ringbuffer/backend_types.h                                             |    1 
 drivers/staging/lttng/wrapper/ringbuffer/config.h                                                    |    1 
 drivers/staging/lttng/wrapper/ringbuffer/frontend.h                                                  |    1 
 drivers/staging/lttng/wrapper/ringbuffer/frontend_api.h                                              |    1 
 drivers/staging/lttng/wrapper/ringbuffer/frontend_internal.h                                         |    1 
 drivers/staging/lttng/wrapper/ringbuffer/frontend_types.h                                            |    1 
 drivers/staging/lttng/wrapper/ringbuffer/iterator.h                                                  |    1 
 drivers/staging/lttng/wrapper/ringbuffer/nohz.h                                                      |    1 
 drivers/staging/lttng/wrapper/ringbuffer/vatomic.h                                                   |    1 
 drivers/staging/lttng/wrapper/ringbuffer/vfs.h                                                       |    1 
 drivers/staging/lttng/wrapper/spinlock.h                                                             |   26 
 drivers/staging/lttng/wrapper/splice.c                                                               |   46 
 drivers/staging/lttng/wrapper/splice.h                                                               |   23 
 drivers/staging/lttng/wrapper/trace-clock.h                                                          |   75 
 drivers/staging/lttng/wrapper/uuid.h                                                                 |   29 
 drivers/staging/lttng/wrapper/vmalloc.h                                                              |   49 
 drivers/staging/lttng/instrumentation/events/README                                                  |    7 
 drivers/staging/lttng/instrumentation/events/lttng-module/block.h                                    |  626 ++
 drivers/staging/lttng/instrumentation/events/lttng-module/irq.h                                      |  155 
 drivers/staging/lttng/instrumentation/events/lttng-module/kvm.h                                      |  312 +
 drivers/staging/lttng/instrumentation/events/lttng-module/lttng.h                                    |   34 
 drivers/staging/lttng/instrumentation/events/lttng-module/sched.h                                    |  400 +
 drivers/staging/lttng/instrumentation/events/lttng-module/syscalls.h                                 |   76 
 drivers/staging/lttng/instrumentation/events/mainline/block.h                                        |  569 ++
 drivers/staging/lttng/instrumentation/events/mainline/irq.h                                          |  150 
 drivers/staging/lttng/instrumentation/events/mainline/kvm.h                                          |  312 +
 drivers/staging/lttng/instrumentation/events/mainline/sched.h                                        |  397 +
 drivers/staging/lttng/instrumentation/events/mainline/syscalls.h                                     |   75 
 drivers/staging/lttng/instrumentation/syscalls/3.0.4/x86-64-syscalls-3.0.4                           |  263 +
 drivers/staging/lttng/instrumentation/syscalls/3.1.0-rc6/x86-32-syscalls-3.1.0-rc6                   |  291 +
 drivers/staging/lttng/instrumentation/syscalls/README                                                |   18 
 drivers/staging/lttng/instrumentation/syscalls/headers/compat_syscalls_integers.h                    |    3 
 drivers/staging/lttng/instrumentation/syscalls/headers/compat_syscalls_pointers.h                    |    3 
 drivers/staging/lttng/instrumentation/syscalls/headers/syscalls_integers.h                           |    7 
 drivers/staging/lttng/instrumentation/syscalls/headers/syscalls_integers_override.h                  |   14 
 drivers/staging/lttng/instrumentation/syscalls/headers/syscalls_pointers.h                           |    7 
 drivers/staging/lttng/instrumentation/syscalls/headers/syscalls_pointers_override.h                  |    4 
 drivers/staging/lttng/instrumentation/syscalls/headers/syscalls_unknown.h                            |   55 
 drivers/staging/lttng/instrumentation/syscalls/headers/x86-32-syscalls-3.1.0-rc6_integers.h          | 1163 +++++
 drivers/staging/lttng/instrumentation/syscalls/headers/x86-32-syscalls-3.1.0-rc6_integers_override.h |   38 
 drivers/staging/lttng/instrumentation/syscalls/headers/x86-32-syscalls-3.1.0-rc6_pointers.h          | 2232 ++++++++++
 drivers/staging/lttng/instrumentation/syscalls/headers/x86-32-syscalls-3.1.0-rc6_pointers_override.h |   17 
 drivers/staging/lttng/instrumentation/syscalls/headers/x86-64-syscalls-3.0.4_integers.h              | 1013 ++++
 drivers/staging/lttng/instrumentation/syscalls/headers/x86-64-syscalls-3.0.4_integers_override.h     |    3 
 drivers/staging/lttng/instrumentation/syscalls/headers/x86-64-syscalls-3.0.4_pointers.h              | 2076 +++++++++
 drivers/staging/lttng/instrumentation/syscalls/headers/x86-64-syscalls-3.0.4_pointers_override.h     |    5 
 drivers/staging/lttng/instrumentation/syscalls/lttng-syscalls-extractor/Makefile                     |    1 
 drivers/staging/lttng/instrumentation/syscalls/lttng-syscalls-extractor/lttng-syscalls-extractor.c   |   85 
 drivers/staging/lttng/instrumentation/syscalls/lttng-syscalls-generate-headers.sh                    |  275 +
 drivers/staging/lttng/ltt-ring-buffer-client-discard.c                                               |   21 
 drivers/staging/lttng/ltt-ring-buffer-client-mmap-discard.c                                          |   21 
 drivers/staging/lttng/ltt-ring-buffer-client-mmap-overwrite.c                                        |   21 
 drivers/staging/lttng/ltt-ring-buffer-client-overwrite.c                                             |   21 
 drivers/staging/lttng/ltt-ring-buffer-client.h                                                       |  569 ++
 drivers/staging/lttng/ltt-ring-buffer-metadata-client.c                                              |   21 
 drivers/staging/lttng/ltt-ring-buffer-metadata-client.h                                              |  330 +
 drivers/staging/lttng/ltt-ring-buffer-metadata-mmap-client.c                                         |   21 
 drivers/staging/lttng/ltt-endian.h                                                                   |   31 
 drivers/staging/lttng/ltt-events.c                                                                   | 1009 ++++
 drivers/staging/lttng/ltt-events.h                                                                   |  452 ++
 drivers/staging/lttng/ltt-probes.c                                                                   |  164 
 drivers/staging/lttng/ltt-tracer-core.h                                                              |   28 
 drivers/staging/lttng/ltt-tracer.h                                                                   |   67 
 drivers/staging/lttng/ltt-context.c                                                                  |   93 
 drivers/staging/lttng/lttng-context-nice.c                                                           |   68 
 drivers/staging/lttng/lttng-context-perf-counters.c                                                  |  271 +
 drivers/staging/lttng/lttng-context-pid.c                                                            |   68 
 drivers/staging/lttng/lttng-context-ppid.c                                                           |   71 
 drivers/staging/lttng/lttng-context-prio.c                                                           |   89 
 drivers/staging/lttng/lttng-context-procname.c                                                       |   72 
 drivers/staging/lttng/lttng-context-tid.c                                                            |   68 
 drivers/staging/lttng/lttng-context-vpid.c                                                           |   74 
 drivers/staging/lttng/lttng-context-vppid.c                                                          |   79 
 drivers/staging/lttng/lttng-context-vtid.c                                                           |   74 
 drivers/staging/lttng/lttng-calibrate.c                                                              |   30 
 drivers/staging/lttng/ltt-debugfs-abi.c                                                              |  777 +++
 drivers/staging/lttng/ltt-debugfs-abi.h                                                              |  153 
 drivers/staging/lttng/LICENSE                                                                        |   27 
 drivers/staging/lttng/README                                                                         |   48 
 drivers/staging/lttng/TODO                                                                           |  137 
 drivers/staging/lttng/lttng-syscalls.c                                                               |  438 +
 drivers/staging/lttng/probes/Makefile                                                                |   37 
 drivers/staging/lttng/probes/define_trace.h                                                          |  132 
 drivers/staging/lttng/probes/lttng-events-reset.h                                                    |   84 
 drivers/staging/lttng/probes/lttng-events.h                                                          |  703 +++
 drivers/staging/lttng/probes/lttng-ftrace.c                                                          |  188 
 drivers/staging/lttng/probes/lttng-kprobes.c                                                         |  164 
 drivers/staging/lttng/probes/lttng-kretprobes.c                                                      |  277 +
 drivers/staging/lttng/probes/lttng-probe-block.c                                                     |   31 
 drivers/staging/lttng/probes/lttng-probe-irq.c                                                       |   31 
 drivers/staging/lttng/probes/lttng-probe-kvm.c                                                       |   31 
 drivers/staging/lttng/probes/lttng-probe-lttng.c                                                     |   24 
 drivers/staging/lttng/probes/lttng-probe-sched.c                                                     |   30 
 drivers/staging/lttng/probes/lttng-type-list.h                                                       |   21 
 drivers/staging/lttng/probes/lttng-types.c                                                           |   49 
 drivers/staging/lttng/probes/lttng-types.h                                                           |   72 
 drivers/staging/lttng/probes/lttng.h                                                                 |   15 
 drivers/staging/lttng/Kconfig                                                                        |   35 
 drivers/staging/lttng/Makefile                                                                       |   33 
 drivers/staging/Kconfig                                                                              |    2 
 drivers/staging/Makefile                                                                             |    1 
 MAINTAINERS                                                                                          |    7 
 135 files changed, 25947 insertions(+)

Thanks!

Mathieu



More information about the lttng-dev mailing list