[ltt-dev] [PATCH 09/10 round10] fix comments of cds_lfht_new()

Mathieu Desnoyers mathieu.desnoyers at efficios.com
Wed Nov 23 00:46:18 EST 2011


Merged as:

commit 44bbe7fa346773b33bf9024efea88705c2f6f476
Author: Lai Jiangshan <laijs at cn.fujitsu.com>
Date:   Wed Nov 23 06:44:35 2011 +0100

    Update comments of cds_lfht_new()
    
    Signed-off-by: Lai Jiangshan <laijs at cn.fujitsu.com>
    Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers at efficios.com>

diff --git a/urcu/rculfhash.h b/urcu/rculfhash.h
index 9208011..5754719 100644
--- a/urcu/rculfhash.h
+++ b/urcu/rculfhash.h
@@ -117,6 +117,8 @@ struct cds_lfht *_cds_lfht_new(unsigned long init_size,
  * @flags: hash table creation flags (can be combined with bitwise or: '|').
  *           0: no flags.
  *           CDS_LFHT_AUTO_RESIZE: automatically resize hash table.
+ *           CDS_LFHT_ACCOUNTING: count the number of node addition
+ *                                and removal in the table
  * @attr: optional resize worker thread attributes. NULL for default.
  *
  * Return NULL on error.
@@ -129,7 +131,8 @@ struct cds_lfht *_cds_lfht_new(unsigned long init_size,
  * this priority level. Having lower priority for call_rcu and resize threads
  * does not pose any correctness issue, but the resize operations could be
  * starved by updates, thus leading to long hash table bucket chains.
- * Threads calling this API need to be registered RCU read-side threads.
+ * Threads calling this API are NOT required to be registered RCU read-side
+ * threads. It can be called very early.(before rcu is initialized ...etc.)
  */
 static inline
 struct cds_lfht *cds_lfht_new(unsigned long init_size,

-- 
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com




More information about the lttng-dev mailing list