[ltt-dev] [PATCH 5/9] use random value for hash value directly

Mathieu Desnoyers mathieu.desnoyers at efficios.com
Tue Nov 15 06:20:02 EST 2011


* Lai Jiangshan (laijs at cn.fujitsu.com) wrote:
[...]
>  struct lfht_test_node {
>  	struct cds_lfht_node node;
> -	void *key;
> -	unsigned int key_len;
> +	unsigned long hash;
>  	/* cache-cold for iteration */
>  	struct rcu_head head;

I'm really unsure about this. One of the test-case should be to walk
through identical-hash-value-chain and find the right node by matching
its key. If we make the hash equal to the key, we don't test the "match"
code anymore.

Thanks,

Mathieu

-- 
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com




More information about the lttng-dev mailing list