[ltt-dev] [UST PATCH] Get Online targets checker

[Mathieu Desnoyers]

* Matthew Khouzam (matthew.khouzam at ericsson.com) wrote:
> Add a check in get online pids
>
> Only sends the pids that are currently online.
>
> Signed-off-by: Matthew Khouzam<matthew.khouzam at ericsson.com>
> ---
>   libustctl/libustctl.c |   14 +++++++++++++-
>   1 files changed, 13 insertions(+), 1 deletions(-)
>
> diff --git a/libustctl/libustctl.c b/libustctl/libustctl.c
> index d57e645..9317440 100644
> --- a/libustctl/libustctl.c
> +++ b/libustctl/libustctl.c
> @@ -92,6 +92,8 @@ pid_t *ustctl_get_online_pids(void)
>   {
>       struct dirent *dirent;
>       DIR *dir;
> +    DIR *proc_dir;
> +    char proc_dir_path[PATH_MAX];

Is it me or your mail client turned all tabs into spaces ?

You should probably read Documentation/SubmittingPatches and
Documentation/email-clients.txt from the kernel source tree.

Thanks,

Mathieu

>       unsigned int ret_size = 1 * sizeof(pid_t), i = 0;
>
>       dir = opendir(SOCK_DIR);
> @@ -117,7 +119,17 @@ pid_t *ustctl_get_online_pids(void)
>                * We need to figure out an intelligent way of solving
>                * this, maybe connect-disconnect.
>                */
> -            if (1) {
> +             snprintf(proc_dir_path, PATH_MAX, "/proc/%u/", ret[i]);
> +             proc_dir = opendir(proc_dir_path);
> +             /*
> +              * Note:
> +              * maybe we should remove the empty dir in this pass
> +              * too. Since the detection method is not perfect,
> +              * this step is not yet implemented.
> +              * A process can die, and its pid can be still taken
> +              * when reading online pids.
> +              */
> +             if (proc_dir) {
>                   ret_size += sizeof(pid_t);
>                   ret = (pid_t *) realloc(ret, ret_size);
>                   ++i;
> -- 1.7.0.4
>

> _______________________________________________
> ltt-dev mailing list
> ltt-dev at lists.casi.polymtl.ca
> http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev


-- 
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com