[ltt-dev] [UST PATCH] Get Online targets checker

[Alexandre Montplaisir]

On 11-03-28 01:12 PM, Matthew Khouzam wrote:
> Added a check in get online pids to only send the pids that are
> currently online.
> Now passes checkpactch.pl and
> has no obvious style problems and is ready for submission.
>
> Signed-off-by: Matthew Khouzam <matthew.khouzam at ericsson.com>
> ---

I have to nitpick here (we can't let you go can we ;) )

The first line of git messages should be at the present tense ("Add a
check...") and not go over 50 characters.
The second line should ALWAYS be empty.
If you use a real editor to generate the commits (like vim, not the one
in Eclipse for example...) it will warn you of those things.


Handy link:
http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html

-- 
Alexandre Montplaisir
DORSAL lab,
École Polytechnique de Montréal