[ltt-dev] Please use underscore variable names in macros (to avoid conflicts)

Paul Wögerer paul_woegerer at mentor.com
Mon Mar 28 08:09:45 EDT 2011


Hi,

The following trivial piece of code will result in corrupt events:

void dump_ackerman_current( int m, int n )
{
     trace_mark( ackerman, current, "m %d n %d", m, n );
}

This is because in ust/marker.h line 173 the definition of the 
__trace_mark_counter macro uses a temporary named m (which shadows the 
original m). It might be a good idea to use underscore variable names 
inside these macros to make naming conflicts less likely.

Thanks,
Paul




More information about the lttng-dev mailing list