[ltt-dev] [UST PATCH] Code base to fix the print errors in UST (v3)

[David Goulet]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1



On 11-03-02 12:30 PM, Yannick Brosseau wrote:
> From: David Goulet <david.goulet at polymtl.ca>

>  		/* Check if subbuf was fully written. This is from Mathieu's algorithm/paper. */
>  		/* FIXME: not sure data_size = 0xffffffff when the buffer is not full. It might
>  		 * take the value of the header size initially */
> @@ -136,9 +190,15 @@ void finish_consuming_dead_subbuffer(struct ustconsumer_callbacks *callbacks, st
>  		/* TODO: check on_read_partial_subbuffer return value */
>  		if(callbacks->on_read_partial_subbuffer)
>  			callbacks->on_read_partial_subbuffer(callbacks, buf, i_subbuf, valid_length);

> +		
git am does not like these whitespaces... Might be a good idea to remove them
before merging. I know it's useless but ... cleaner :)

There is also two unused variable now :

buffers.c:260: warning: unused variable ‘cpu’
buffers.c:259: warning: unused variable ‘chan’

We should remove that warning.

Apart from that, it's working good on my side. All my tests and UST tests are good.

Thanks
David

> +		/* Manually increment the consumed offset */
> +		/* TODO ybrosseau 2011-03-02: Should only be done if the previous read was successful */
> +		uatomic_add(&ustbuf->consumed, buf->subbuf_size);
>  
>  		if(i_subbuf == last_subbuf % buf->n_subbufs)
>  			break;
>  	}
> +
> +	ltt_relay_print_buffer_errors(buf, buf->channel_cpu);
>  }
>  

- -- 
David Goulet
LTTng project, DORSAL Lab.

1024D/16BD8563
BE3C 672B 9331 9796 291A  14C6 4AF7 C14B 16BD 8563
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAk1uhf0ACgkQSvfBSxa9hWPGcgCgjA+utPE4mPyYiQWttCiqsWlI
3uIAn3L7qmLc2Mxgstf7bVe7I+r7JmVi
=qPSS
-----END PGP SIGNATURE-----