[ltt-dev] [UST PATCH] TESTS: Add a delay at the start of the fork test for a more uniform testing.

Nils Carlson nils.carlson at ericsson.com
Wed Feb 23 03:36:49 EST 2011


Yannick Brosseau wrote:
> Add a sleep to leave time for the ustconsumer thread to initialize correctly
> before the fork.
> Most of the time the consumer was not yet started at the time of the fork so
> a bunch of initializations were not done and the fork code path was not
> tested properly.
>
> Signed-off-by: Yannick Brosseau <yannick.brosseau at gmail.com>
>   
    Acked-by: Nils Carlson <nils.carlson at ericsson.com>

> ---
>  tests/fork/fork.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/tests/fork/fork.c b/tests/fork/fork.c
> index 5ce3d6d..a80518d 100644
> --- a/tests/fork/fork.c
> +++ b/tests/fork/fork.c
> @@ -34,6 +34,9 @@ int main(int argc, char **argv, char *env[])
>  	printf("Fork test program, parent pid is %d\n", getpid());
>  	trace_mark(ust, before_fork, MARK_NOARGS);
>  
> +	/* Sleep here to make sure the consumer is initialized before we fork */
> +	sleep(1);
> +
>  	result = fork();
>  	if(result == -1) {
>  		perror("fork");
>   





More information about the lttng-dev mailing list