[ltt-dev] [LTTV PATCH] Reactivate the constructor of the filter and control dialogs

Yannick Brosseau yannick.brosseau at gmail.com
Fri Feb 4 15:58:36 EST 2011


Both constructor were accidently removed in the warning cleanup

Signed-off-by: Yannick Brosseau <yannick.brosseau at gmail.com>
---
 lttv/modules/gui/filter/filter.c             |    5 ++++-
 lttv/modules/gui/tracecontrol/tracecontrol.c |    6 +++++-
 2 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/lttv/modules/gui/filter/filter.c b/lttv/modules/gui/filter/filter.c
index 2357465..a69685f 100644
--- a/lttv/modules/gui/filter/filter.c
+++ b/lttv/modules/gui/filter/filter.c
@@ -462,7 +462,10 @@ gui_filter_destructor(FilterViewerData *fvd)
 GtkWidget *
 h_guifilter(LttvPlugin *plugin)
 {
-  return NULL;
+	gui_filter(plugin);
+
+	/* TODO ybrosseau 2011-02-04: We should probably return a widget here */
+	return NULL;
 }
 
 /**
diff --git a/lttv/modules/gui/tracecontrol/tracecontrol.c b/lttv/modules/gui/tracecontrol/tracecontrol.c
index a02301b..56165d9 100644
--- a/lttv/modules/gui/tracecontrol/tracecontrol.c
+++ b/lttv/modules/gui/tracecontrol/tracecontrol.c
@@ -1242,7 +1242,11 @@ void disarm_clicked (GtkButton *button, gpointer user_data)
 GtkWidget *
 h_guicontrol(LttvPlugin *plugin)
 {
-  return NULL;
+	LttvPluginTab *ptab = LTTV_PLUGIN_TAB(plugin);
+	gui_control(ptab) ;
+
+	/* TODO ybrosseau 2011-02-04: We should probably return a widget here */
+	return NULL;
 }
 
 /**
-- 
1.7.2.3





More information about the lttng-dev mailing list