[ltt-dev] [PATCH] Fix choice of default flavour in urcu/map/urcu.h

Duncan Sands baldrick at free.fr
Tue Aug 16 04:12:32 EDT 2011


Hi, I noticed in the 0.64 release (and git too) that if a flavour is not
specified explicitly then RCU_MB is chosen in urcu/map/urcu.h, while the
docs say and the Makefile expects RCU_MEMBARRIER.  Note that the header
file urcu/static/urcu.h has similar logic but uses RCU_MEMBARRIER for the
default.

Before this patch:

$ nm *.a | grep rcu_init
00000000000003c0 T rcu_init_mb
00000000000003c0 T rcu_init_mb
0000000000000000 T rcu_init_sig

After this patch:

$ nm *.a | grep rcu_init
00000000000003c0 T rcu_init_memb
00000000000003c0 T rcu_init_mb
0000000000000000 T rcu_init_sig


Index: urcu/map/urcu.h
===================================================================
--- urcu/map/urcu.h
+++ urcu/map/urcu.h
@@ -35,7 +35,7 @@
  /* Mapping macros to allow multiple flavors in a single binary. */

  #if !defined(RCU_MEMBARRIER) && !defined(RCU_SIGNAL) && !defined(RCU_MB)
-#define RCU_MB
+#define RCU_MEMBARRIER
  #endif

  #ifdef RCU_MEMBARRIER




More information about the lttng-dev mailing list