[ltt-dev] [UST PATCH] Only send the pids that are currently online in ustctl_get_online_pids().

[Mathieu Desnoyers]

* Matthew Khouzam (matthew.khouzam at gmail.com) wrote:
> Signed-off-by: Matthew Khouzam <matthew.khouzam at ericsson.com>
> ---
>  libustctl/libustctl.c |   19 ++++++++++++++++++-
>  1 files changed, 18 insertions(+), 1 deletions(-)
> 
> diff --git a/libustctl/libustctl.c b/libustctl/libustctl.c
> index d57e645..07c81f3 100644
> --- a/libustctl/libustctl.c
> +++ b/libustctl/libustctl.c
> @@ -92,6 +92,8 @@ pid_t *ustctl_get_online_pids(void)
>  {
>  	struct dirent *dirent;
>  	DIR *dir;
> +	DIR *proc_dir;
> +	char proc_dir_path[PATH_MAX];
>  	unsigned int ret_size = 1 * sizeof(pid_t), i = 0;
>  
>  	dir = opendir(SOCK_DIR);
> @@ -117,7 +119,22 @@ pid_t *ustctl_get_online_pids(void)
>  			 * We need to figure out an intelligent way of solving
>  			 * this, maybe connect-disconnect.
>  			 */
> -			if (1) {
> +			 snprintf(proc_dir_path, PATH_MAX, "/proc/%u/", ret[i]);
> +			 proc_dir = opendir(proc_dir_path);
> +			 /*
> +			  * Note:
> +			  * We should not remove the empty dir in this pass.
> +			  * A process can die, a new process can be born and
> +			  * assigned to that PID. the only way to avoid this

I'll take it from here and fix the leftovers.

the -> The

"The only way" -> "One natural way"

> +			  * would be to de-register and register centrally.
> +			  * Ltt-sessiond would be a good candidate for such a
> +			  * location.
> +			  */
> +			 if (proc_dir) {

/* We... -> /*
             * We...

I'll merge the patch with these changes.

Thanks,

Mathieu

> +				/* We only needed to check if it's valid
> +				 * so we close it here
> +				 */
> +				closedir(proc_dir);
>  				ret_size += sizeof(pid_t);
>  				ret = (pid_t *) realloc(ret, ret_size);
>  				++i;
> -- 
> 1.7.0.4
> 
> 
> _______________________________________________
> ltt-dev mailing list
> ltt-dev at lists.casi.polymtl.ca
> http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev
> 

-- 
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com