[ltt-dev] [UST] malloc error found by david
David Goulet
david.goulet at polymtl.ca
Wed Sep 29 19:01:53 EDT 2010
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 10-09-29 04:40 PM, Mathieu Desnoyers wrote:
> Hi Nils,
>
> Please double-check that you ported commit
>
> 38516ab59fbc5b3bb278cf5e1fe2867c70cff32e
>
> tracing: Let tracepoints have data passed to tracepoint callbacks
>
> correctly from mainline. There is at least a bug in
>
> static inline void *allocate_probes(int count)
>
> (sizeof(void *) should be changed for sizeof(struct tracepoint_func))
Yes, but for UST, it's sizeof(struct probe), actually almost the same but
different name :P
This was introduce in UST from commit (in libust/tracepoint.c)
1dba3e6c054da18f238d051da5b1839bd5e4e4dd
I really have NO idea how it came in because for that commit I only changed the
malloc to zmalloc. So I think, somekind of "merge" between patches went wrong
and git didn't notice. Shit happens ;)
Thanks
David
>
> Hopefully no other bugs crept in.
>
> Credits go to David Goulet, how just spent 2 days hunting this one down.
>
> Thanks,
>
> Mathieu
>
>
>
- --
David Goulet
LTTng project, DORSAL Lab.
1024D/16BD8563
BE3C 672B 9331 9796 291A 14C6 4AF7 C14B 16BD 8563
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
iEYEARECAAYFAkyjxWEACgkQSvfBSxa9hWPcUQCePVOAXil4Qi5L53XPY5sx1yH3
U+AAoLqnA+GDQz1BM3Cp6c1rMMgq+Lcp
=Uken
-----END PGP SIGNATURE-----
More information about the lttng-dev
mailing list