[ltt-dev] [UST PATCH] Add a valgrind suppression for sendmsg (v2)

[David Goulet]

Acked-by: David Goulet <david.goulet at polymtl.ca>

On 10-10-11 02:43 PM, Nils Carlson wrote:
> Changes since v1: Make the suppression match libc and
> libpthread, multiple versions.
>
> For some reason valgrind thinks the iov array in ustcomm_send_fd
> is used uninitialised. Add a suppression so this won't show as
> an error.
>
> Signed-off-by: Nils Carlson<nils.carlson at ericsson.com>
> ---
>   tests/valgrind_suppress.txt |   14 ++++++++++++++
>   tests/valgrind_ustd.sh      |    2 +-
>   2 files changed, 15 insertions(+), 1 deletions(-)
>   create mode 100644 tests/valgrind_suppress.txt
>
> diff --git a/tests/valgrind_suppress.txt b/tests/valgrind_suppress.txt
> new file mode 100644
> index 0000000..2a4ac36
> --- /dev/null
> +++ b/tests/valgrind_suppress.txt
> @@ -0,0 +1,14 @@
> +{
> +   sendmsg-iov-errors-libpthread
> +   Memcheck:Param
> +   socketcall.sendmsg(msg.msg_iov[i])
> +   obj:/lib/libpthread-2.*
> +   fun:ustcomm_send_fd
> +}
> +{
> +   sendmsg-iov-errors-libc
> +   Memcheck:Param
> +   socketcall.sendmsg(msg.msg_iov[i])
> +   obj:/lib/libc-2.*
> +   fun:ustcomm_send_fd
> +}
> diff --git a/tests/valgrind_ustd.sh b/tests/valgrind_ustd.sh
> index 532022d..541d8ca 100755
> --- a/tests/valgrind_ustd.sh
> +++ b/tests/valgrind_ustd.sh
> @@ -34,7 +34,7 @@ pidfilepath="/tmp/ust-testsuite-$USER-$(date +%Y%m%d%H%M%S%N)-ustd-pid"
>   mkfifo -m 0600 "$pidfilepath"
>
>   VALG_OUT=/tmp/ust-testsuite-valg.txt
> -valgrind -q ustd --pidfile "$pidfilepath" -o "$TRACE_DIR">/dev/null 2>"$VALG_OUT"&
> +valgrind --suppressions=$TESTDIR/valgrind_suppress.txt -q ustd --pidfile "$pidfilepath" -o "$TRACE_DIR">/dev/null 2>"$VALG_OUT"&
>   VALG_PID=$!
>   USTD_PID="$(<$pidfilepath)"
>

-- 
David Goulet
LTTng project, DORSAL Lab.

PGP/GPG : 1024D/16BD8563
BE3C 672B 9331 9796 291A  14C6 4AF7 C14B 16BD 8563