[ltt-dev] [PATCH 07/11] add uatomic_gcc.h, use it for default definitions

[Mathieu Desnoyers]

* Paolo Bonzini (pbonzini at redhat.com) wrote:
> On 02/15/2010 05:51 PM, Mathieu Desnoyers wrote:
>>>>
>>>> I was thinking of doing (3) with the additional twist that S390
>>>> would count as a "new architecture".  On it, GCC is providing
>>>> really everything that is needed and furthermore, unlike PPC,
>>>> your testers surely have a new-enough GCC because they're using
>>>> api_gcc.h.
>> Hrm. As things stand, I would recommend plainly going with (3),
>> using gcc builtins only for the new architectures which are not
>> supported at the moment, being ready to merge compatibility code for
>> these architectures if we see the need for it at some point.
>>
>> From this point of view, moving s390 from the custom operations to
>> gcc builtins seems like a step backward.
>
> Fine, will adjust.
>
>> I'd prefer to look into the api_gcc.h issues and fix those so we can
>> ensure that sparc64 and s390 are OK with older gcc.
>
> Requiring GCC for testing purposes doesn't seem too bad, but I guess  
> this latest paragraph was a kind of "patches are welcome" thing. :-)

Exactly ;)

Thanks,

Mathieu

>
> Paolo
>

-- 
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68