[ltt-dev] More build errors with lttng-0.209 + 2.6.33.2 x86_64 -- i7300_idle.c IDLE_START/IDLE_END

[Mathieu Desnoyers]

* VK (list-lttng at kutty.cc) wrote:
>
> Error from make:
>
> drivers/idle/i7300_idle.c: In function ‘i7300_idle_notifier’:
> drivers/idle/i7300_idle.c:460: error: ‘IDLE_START’ undeclared (first  
> use in this function)
> drivers/idle/i7300_idle.c:460: error: (Each undeclared identifier is  
> reported only once
> drivers/idle/i7300_idle.c:460: error: for each function it appears in.)
> drivers/idle/i7300_idle.c:480: error: ‘IDLE_END’ undeclared (first 
> use in this function)
> drivers/idle/i7300_idle.c: In function ‘i7300_idle_init’:
> drivers/idle/i7300_idle.c:585: error: implicit declaration of function  
> ‘idle_notifier_register’
> drivers/idle/i7300_idle.c: In function ‘i7300_idle_exit’:
> drivers/idle/i7300_idle.c:593: error: implicit declaration of function  
> ‘idle_notifier_unregister’
> make[2]: *** [drivers/idle/i7300_idle.o] Error 1
> make[1]: *** [drivers/idle] Error 2
>
>
> Possible solution?:
>
>
> *** drivers/idle/i7300_idle.c.orig      2010-04-01 18:02:33.000000000  
> -0500
> --- drivers/idle/i7300_idle.c   2010-04-12 00:41:43.000000000 -0500
> ***************
> *** 26,31 ****
> --- 26,32 ----
>   #include <linux/debugfs.h>
>   #include <linux/stop_machine.h>
>   #include <linux/i7300_idle.h>
> + #include <linux/idle.h>
>
>   #include <asm/idle.h>
>
> ***************
> *** 582,588 ****
>                 }
>         }
>
> !       idle_notifier_register(&i7300_idle_nb);
>
>         printk(KERN_INFO "i7300_idle: loaded v%s\n",  
> I7300_IDLE_DRIVER_VERSION);
>         return 0;
> --- 583,589 ----
>                 }
>         }
>
> !       register_idle_notifier(&i7300_idle_nb);
>
>         printk(KERN_INFO "i7300_idle: loaded v%s\n",  
> I7300_IDLE_DRIVER_VERSION);
>         return 0;
> ***************
> *** 590,596 ****
>
>   static void __exit i7300_idle_exit(void)
>   {
> !       idle_notifier_unregister(&i7300_idle_nb);
>         free_cpumask_var(idle_cpumask);
>
>         if (debugfs_dir) {
> --- 591,597 ----
>
>   static void __exit i7300_idle_exit(void)
>   {
> !       unregister_idle_notifier(&i7300_idle_nb);
>         free_cpumask_var(idle_cpumask);
>
>         if (debugfs_dir) {
>

Yep, will fix.

Thanks !

Mathieu

>
>
> -----------------------------
>
>
> --
> Vinod
>
> _______________________________________________
> ltt-dev mailing list
> ltt-dev at lists.casi.polymtl.ca
> http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev
>

-- 
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com