[ltt-dev] Errors building lttng 0.209 + linux-2.6.33.2

[Mathieu Desnoyers]

* VK (list-lttng at kutty.cc) wrote:
>
> Hi,
>
> It's been years since I tried lttng. Just trying to get it built with  
> 2.6.33.2 on top of a RHEL 5.4 x86_64 system and running into a lot of  
> probs.
>
> Here are some errors along with possible solutions. I was just trying to  
> get things to build, so I don't know if these are correct or not. Not  
> something I do often enough to recognize simple "user errors" 8-)
>
> Some of them (e.g. asm vs asm-x86 ) seem like I may be missing something  
> else that should automagically do the right thing.
>


Hi Vinod,

Thanks for reporting these errors, let's dig through them.

>
> 1.
> security/selinux/netnode.c: In function ‘sel_netnode_insert’:
> security/selinux/netnode.c:185: error: implicit declaration of function  
> ‘INIT_RCU_HEAD’
> make[2]: *** [security/selinux/netnode.o] Error 1
> make[1]: *** [security/selinux] Error 2
>
> Possible solution?:
>
> *** security/selinux/netnode.c.orig     2010-04-01 18:02:33.000000000  
> -0500
> --- security/selinux/netnode.c  2010-04-12 14:38:12.000000000 -0500
> ***************
> *** 182,188 ****
>                 BUG();
>         }
>
> !       INIT_RCU_HEAD(&node->rcu);
>
>         /* we need to impose a limit on the growth of the hash table so  
> check
>          * this bucket to make sure it is within the specified bounds */
> --- 182,188 ----
>                 BUG();
>         }
>
> !       rcu_head_init(&node->rcu);
>
>         /* we need to impose a limit on the growth of the hash table so  
> check
>          * this bucket to make sure it is within the specified bounds */
>

Yep. Will fix for lttng 0.211.

>
> -----------------------------------------------------------------------
>
>
>
> 2.
> arch/x86/kernel/call_export_64.c:10:25: error: asm/call_64.h: No such 
> file or directory
> make[2]: *** [arch/x86/kernel/call_export_64.o] Error 1
>
>
> Possible solution?:
>
> *** arch/x86/kernel/call_export_64.c.orig       2010-04-12  
> 14:30:51.000000000 -0500
> --- arch/x86/kernel/call_export_64.c    2010-04-12 14:39:53.000000000  
> -0500
> ***************
> *** 7,13 ****
>    */
>
>   #include <linux/module.h>
> ! #include <asm/call_64.h>
>
>   void asm_psread_lock_slow_irq(void);
>   EXPORT_SYMBOL_GPL(asm_psread_lock_slow_irq);
> --- 7,13 ----
>    */
>
>   #include <linux/module.h>
> ! #include <asm-x86/call_64.h>
>
>   void asm_psread_lock_slow_irq(void);
>   EXPORT_SYMBOL_GPL(asm_psread_lock_slow_irq);
>

You should probably try to backup your .config file and do a make
mrproper.

> -----------------------------------------------------------------------
>
>
> 3.
> security/selinux/avc.c: In function ‘avc_alloc_node’:
> security/selinux/avc.c:291: error: implicit declaration of function  
> ‘INIT_RCU_HEAD’
> make[2]: *** [security/selinux/avc.o] Error 1
> make[1]: *** [security/selinux] Error 2
>
> Possible solution?:
>
> *** security/selinux/avc.c.orig 2010-04-01 18:02:33.000000000 -0500
> --- security/selinux/avc.c      2010-04-12 14:41:07.000000000 -0500
> ***************
> *** 288,294 ****
>         if (!node)
>                 goto out;
>
> !       INIT_RCU_HEAD(&node->rhead);
>         INIT_HLIST_NODE(&node->list);
>         avc_cache_stats_incr(allocations);
>
> --- 288,294 ----
>         if (!node)
>                 goto out;
>
> !       rcu_head_init(&node->rhead);
>         INIT_HLIST_NODE(&node->list);
>         avc_cache_stats_incr(allocations);
>

will fix.

>
> -----------------------------------------------------------------------
>
> 4.
> In file included from lib/psrwlock.c:13:
> include/linux/psrwlock.h:135:25: error: asm/call_64.h: No such file or  
> directory
>

make mrproper should fix it.

>
>
> Possible solution?:
>
> *** include/linux/psrwlock.h.orig       2010-04-12 14:30:51.000000000  
> -0500
> --- include/linux/psrwlock.h    2010-04-12 17:30:09.000000000 -0500
> ***************
> *** 132,138 ****
>   void _psrwlock_wakeup(unsigned int uc, psrwlock_t *rwlock);
>
>   #ifdef CONFIG_HAVE_PSRWLOCK_ASM_CALL
> ! #include <asm/call_64.h>
>   #else
>   #define psread_lock_slow_irq          _psread_lock_slow_irq
>   #define psread_trylock_slow_irq               _psread_trylock_slow_irq
> --- 132,138 ----
>   void _psrwlock_wakeup(unsigned int uc, psrwlock_t *rwlock);
>
>   #ifdef CONFIG_HAVE_PSRWLOCK_ASM_CALL
> ! #include <asm-x86/call_64.h>
>   #else
>   #define psread_lock_slow_irq          _psread_lock_slow_irq
>   #define psread_trylock_slow_irq               _psread_trylock_slow_irq
>
>
>
> -----------------------------------------------------------------------
>

Will follow up with your next email.

Thanks,

Mathieu

>
> --
> Vinod
>
> _______________________________________________
> ltt-dev mailing list
> ltt-dev at lists.casi.polymtl.ca
> http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev
>

-- 
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com