[ltt-dev] LTTng 0.140 for Linux 2.6.30

[Benjamin Poirier]

Mathieu Desnoyers wrote:
> * Benjamin Poirier (benjamin.poirier at polymtl.ca) wrote:
>> Mathieu Desnoyers wrote:
>>> Hi,
>>>
>>> I just released LTTng 0.140 for the new kernel of the day. There were
>>> very few conflicts to resolve since the 2.6.30-rc5 version. None in the
>>> tracer "driver" part, only few in the overall kernel instrumentation.
>>>
>>> Provided as-is, given my main test machine is currently busy running
>>> some formal verification. It builds fine though.
>>>
>>> As always, available on the kernel.org lttng tree and as a patchset. See
>>> http://www.lttng.org for details.
>>>
>>> Mathieu
>>>
>>>
>>>   
>> Hello Mathieu,
>>
>> I'm having problems building the most recent version of Lttng:
> 
> Hi Benjamin,
> 
> I just pushed the fixed LTTng 0.141. It only affects TREE_RCU builds.

Thank you,

Regarding the fix you made, I believe the documentation should also be updated
accordindly:

--- a/Documentation/markers.txt
+++ b/Documentation/markers.txt
@@ -83,12 +83,12 @@ with tracepoint probes in a scheme like this :
 
 void probe_tracepoint_name(unsigned int arg1, struct task_struct *tsk);
 
-DEFINE_MARKER_TP(marker_eventname, tracepoint_name, probe_tracepoint_name,
-	"arg1 %u pid %d");
+DEFINE_MARKER_TP(marker_channel, marker_eventname, tracepoint_name,
+	probe_tracepoint_name, "arg1 %u pid %d");
 
 notrace void probe_tracepoint_name(unsigned int arg1, struct task_struct *tsk)
 {
-	struct marker *marker = &GET_MARKER(kernel_irq_entry);
+	struct marker *marker = &GET_MARKER(marker_channel, marker_eventname);
 	/* write data to trace buffers ... */
 }

---

Also, from what I understood, and you can confirm this, using DEFINE_MARKER_TP
removes the need to connect the probe to the tracepoint "manually", ie. using
register_trace_subsys_eventname()? This might also be worth mentionning in the
documentation. At least, it wasn't clear to me.

-Ben

> 
> Thanks for reporting this !
> 
> Mathieu
> 
>> $ make i386_defconfig
>> $ make menuconfig
>> # Linux Trace Toolkit Next Generation (LTTng) = y
>> $ make
>> [...]
>> CC [M] ltt/probes/rcu-trace.o
>> ltt/probes/rcu-trace.c: In function ‘__check_tp_type’:
>> ltt/probes/rcu-trace.c:55: error: implicit declaration of function
>> ‘register_trace_probe_rcu_tree_callback’
>> ltt/probes/rcu-trace.c: In function ‘probe_rcu_tree_callback’:
>> ltt/probes/rcu-trace.c:55: error: expected ‘,’ or ‘;’ before ‘head’
>> ltt/probes/rcu-trace.c:55: warning: passing argument 1 of
>> ‘___mark_check_format’ from incompatible pointer type
>> ltt/probes/rcu-trace.c: In function ‘__check_tp_type’:
>> ltt/probes/rcu-trace.c:61: error: implicit declaration of function
>> ‘register_trace_probe_rcu_tree_call_rcu’
>> ltt/probes/rcu-trace.c: In function ‘probe_rcu_tree_call_rcu’:
>> ltt/probes/rcu-trace.c:61: error: expected ‘,’ or ‘;’ before ‘head’
>> ltt/probes/rcu-trace.c:61: warning: passing argument 1 of
>> ‘___mark_check_format’ from incompatible pointer type
>> ltt/probes/rcu-trace.c: In function ‘__check_tp_type’:
>> ltt/probes/rcu-trace.c:67: error: implicit declaration of function
>> ‘register_trace_probe_rcu_tree_call_rcu_bh’
>> ltt/probes/rcu-trace.c: In function ‘probe_rcu_tree_call_rcu_bh’:
>> ltt/probes/rcu-trace.c:67: error: expected ‘,’ or ‘;’ before ‘head’
>> ltt/probes/rcu-trace.c:67: warning: passing argument 1 of
>> ‘___mark_check_format’ from incompatible pointer type
>> make[2]: *** [ltt/probes/rcu-trace.o] Error 1
>> make[1]: *** [ltt/probes] Error 2
>> make: *** [ltt] Error 2
>>
>> Can you help?
>>
>> Thanks,
>> -Ben
>>
>> _______________________________________________
>> ltt-dev mailing list
>> ltt-dev at lists.casi.polymtl.ca
>> http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev
>>
>