[ltt-dev] [PATCH 3/5] sh: removed _TIF_KERNEL_TRACE from _TIF_ALLWORK_MASK and _TIF_WORK_MASK

[Giuseppe CAVALLARO]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Mathieu,

Mathieu Desnoyers wrote:
> * Giuseppe CAVALLARO (peppe.cavallaro at st.com) wrote:
>> _TIF_ALLWORK_MASK and _TIF_WORK_MASK need to fit within a byte as
>> described into the header file. So we cannot add _TIF_KERNEL_TRACE
>> till to modify either the entry-common.S or the thread_info.h.
>> In fact, without this patch the assembler fails with the following
>> error:
>>
>> AS      arch/sh/kernel/cpu/sh4/entry.o
>> arch/sh/kernel/cpu/sh4/entry.S: Assembler messages:
>> arch/sh/kernel/cpu/sh4/entry.S:904: Error: offset out of range
>> [snip]
>>
>> This will be reviewed later.
>>
> 
> Hi Giuseppe,
> 
> The other patches looks fine, except this one. We should change the
> instructions in entry.S so they allow TIF larger than 8 bits.

Ok! I'll see how to do that and I let you know.

Peppe

> 
> I'll merge the other patches, but will leave this one aside.
> 
> Thanks,
> 
> Mathieu
> 
>> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro at st.com>
>> ---
>>  arch/sh/include/asm/thread_info.h |    8 +++-----
>>  1 files changed, 3 insertions(+), 5 deletions(-)
>>
>> diff --git a/arch/sh/include/asm/thread_info.h b/arch/sh/include/asm/thread_info.h
>> index 956db84..58cc206 100644
>> --- a/arch/sh/include/asm/thread_info.h
>> +++ b/arch/sh/include/asm/thread_info.h
>> @@ -149,19 +149,17 @@ extern void free_thread_info(struct thread_info *ti);
>>  
>>  /* work to do in syscall trace */
>>  #define _TIF_WORK_SYSCALL_MASK	(_TIF_SYSCALL_TRACE | _TIF_SINGLESTEP | \
>> -				 _TIF_SYSCALL_AUDIT | _TIF_SECCOMP | \
>> -				 _TIF_KERNEL_TRACE)
>> +				 _TIF_SYSCALL_AUDIT | _TIF_SECCOMP)
>>  
>>  /* work to do on any return to u-space */
>>  #define _TIF_ALLWORK_MASK	(_TIF_SYSCALL_TRACE | _TIF_SIGPENDING      | \
>>  				 _TIF_NEED_RESCHED  | _TIF_SYSCALL_AUDIT   | \
>>  				 _TIF_SINGLESTEP    | _TIF_RESTORE_SIGMASK | \
>> -				 _TIF_NOTIFY_RESUME | _TIF_KERNEL_TRACE)
>> +				 _TIF_NOTIFY_RESUME)
>>  
>>  /* work to do on interrupt/exception return */
>>  #define _TIF_WORK_MASK		(_TIF_ALLWORK_MASK & ~(_TIF_SYSCALL_TRACE | \
>> -				 _TIF_SYSCALL_AUDIT | _TIF_SINGLESTEP | \
>> -				 _TIF_KERNEL_TRACE))
>> +				 _TIF_SYSCALL_AUDIT | _TIF_SINGLESTEP))
>>  
>>  /* PR_[GS]ET_UNALIGN prctls */
>>  #define SH_UAC_SHIFT		TIF_UAC_NOPRINT
>> -- 
>> 1.6.0.4
>>
>>
>> _______________________________________________
>> ltt-dev mailing list
>> ltt-dev at lists.casi.polymtl.ca
>> http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev
>>
> 

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkpxoq8ACgkQ2Xo3j31MSSL+fwCgpzr4MseEIeEF/sgiq6k9qeU7
++4An3S9gQkmWULvBZ1FvgtyS7J4DSnU
=Y8ht
-----END PGP SIGNATURE-----