[ltt-dev] [PATCH v2] lttng: remove ltt root directory if it's no needed
Gui Jianfeng
guijianfeng at cn.fujitsu.com
Wed Feb 18 20:16:36 EST 2009
Hi Kosaki-san,
KOSAKI Motohiro wrote:
> Hi
>
>> We have to cleanup the lttng's root directory of debugfs if
>> there is nobody uses it any more.
>
> Why "have to"?
> This description don't explain anything.
Will add more.
>
>
>
> diff --git a/ltt/ltt-trace-control.c b/ltt/ltt-trace-control.c
>> index 16502a2..0cdeb8a 100644
>> --- a/ltt/ltt-trace-control.c
>> +++ b/ltt/ltt-trace-control.c
>> @@ -740,7 +740,8 @@ err_create_destroy_trace_file:
>> err_create_setup_trace_file:
>> debugfs_remove(ltt_control_dir);
>> err_create_control_dir:
>> -err_no_root:
>> + put_ltt_root();
>> + err_no_root:
>
> label indentation is considered bad conding style in lkml.
Thanks for pointing this out. I guess emacs is the culprit.
Emacs add this blank automatically, i missed this. :(
Will post a new one.
>
>
>
>
>
>
>
>
--
Regards
Gui Jianfeng
More information about the lttng-dev
mailing list