[ltt-dev] [PATCH] Don't use select

KOSAKI Motohiro kosaki.motohiro at jp.fujitsu.com
Tue Feb 10 02:46:06 EST 2009


Impact: Kconfig cleanup

many kernel developer hate select Kconfig syntax.
it should be avoided.


Signed-off-by: KOSAKI Motohiro <kosaki.motohiro at jp.fujitsu.com>
---
 ltt/Kconfig |   19 ++++++++++---------
 1 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/ltt/Kconfig b/ltt/Kconfig
index ef93140..1347d6f 100644
--- a/ltt/Kconfig
+++ b/ltt/Kconfig
@@ -1,8 +1,8 @@
 menuconfig LTT
 	bool "Linux Trace Toolkit Next Generation (LTTng)"
 	depends on EXPERIMENTAL
-	select MARKERS
-	select TRACEPOINTS
+	depends on MARKERS
+	depends on TRACEPOINTS
 	default y
 	help
 	  It is possible for the kernel to log important events to a trace
@@ -48,7 +48,7 @@ config LTT_RELAY_ALLOC
 
 config LTT_RELAY
 	tristate "Linux Trace Toolkit High-speed Lockless Data Relay"
-	select DEBUG_FS
+	depends on DEBUG_FS
 	select LTT_RELAY_ALLOC
 	depends on LTT_TRACER
 	default y
@@ -61,7 +61,7 @@ config LTT_RELAY
 
 config LTT_RELAY_LOCKED
 	tristate "Linux Trace Toolkit Lock-Protected Data Relay"
-	select DEBUG_FS
+	depends on DEBUG_FS
 	select LTT_RELAY_ALLOC
 	depends on LTT_TRACER
 	default n
@@ -82,6 +82,7 @@ config LTT_RELAY_CHECK_RANDOM_ACCESS
 config LTT_SERIALIZE
 	tristate "Linux Trace Toolkit Serializer"
 	default y
+	select LTT_RELAY_ALLOC
 	help
 	  Library for serializing information from format string and argument
 	  list to the trace buffers.
@@ -182,9 +183,9 @@ config LTT_STATEDUMP
 
 config LTT_FTRACE
 	bool "Linux Trace Toolkit Function Tracer Support"
-	select LTT_SERIALIZE
-	select LTT_MARKER_CONTROL
-	select FUNCTION_TRACER
+	depends on LTT_SERIALIZE
+	depends on LTT_MARKER_CONTROL
+	depends on FUNCTION_TRACER
 	default n
 	help
 	  Integration of function entry trace with LTTng. Connect the
@@ -197,8 +198,8 @@ config LTT_KPROBES
 	depends on HAVE_KPROBES
 	depends on LTT_MARKER_CONTROL
 	depends on  LTT_TRACEPROBES=y
-	select KPROBES
-	select KALLSYMS
+	depends on KPROBES
+	depends on KALLSYMS
 	default y
 	help
 	  Allows connecting the LTTng tracer on kprobes using simple debugfs
-- 
1.6.0.6







More information about the lttng-dev mailing list