[ltt-dev] [PATCH] LTT_KPROBES is made to depend on LTT_TRACEPROBES

KOSAKI Motohiro kosaki.motohiro at jp.fujitsu.com
Tue Feb 10 02:43:36 EST 2009


Impact: fix build error

if LTT_KPROBES=y and LTT_TRACEPROBES=m, following build error happend.

  ltt/built-in.o: In function `ltt_specialized_trace':
  ltt/probes/ltt-type-serializer.h:26: undefined reference to `_ltt_specialized_trace'
  make: *** [.tmp_vmlinux1] error 1

In addition, many kernel developer hate "select" syntax. it should be avoided.

Signed-off-by: KOSAKI Motohiro <kosaki.motohiro at jp.fujitsu.com>
---
 ltt/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/ltt/Kconfig b/ltt/Kconfig
index 1d80b98..ef93140 100644
--- a/ltt/Kconfig
+++ b/ltt/Kconfig
@@ -196,9 +196,9 @@ config LTT_KPROBES
 	bool "Linux Trace Toolkit Kprobes Support"
 	depends on HAVE_KPROBES
 	depends on LTT_MARKER_CONTROL
+	depends on  LTT_TRACEPROBES=y
 	select KPROBES
 	select KALLSYMS
-	select LTT_TRACEPROBES
 	default y
 	help
 	  Allows connecting the LTTng tracer on kprobes using simple debugfs
-- 
1.6.0.6







More information about the lttng-dev mailing list