[ltt-dev] Compilation error of trace_clock for PowerPC (ppc32)

[srikanth krishnakar]

Hi Mathieu,

Here is a proposed fix for the compilation error:

Date: Tue, 28 Apr 2009 21:29:09 +0530
Subject: [PATCH] lttng: powerpc trace-clock.h include <asm/time.h> for
get_tbl

Make get_tbl() and get_tb() known to powerpc <asm/trace-clock.h> by
having it include <asm/time.h> (where get_tbl() and get_tb() are defined).

This fixes compiler errors when get_tbl() and get_tb() were referenced
by <asm/trace-clock.h> without being defined.

On the other hand, <asm/processor.h> was needlessly included.  Remove it.

---
 arch/powerpc/include/asm/trace-clock.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/powerpc/include/asm/trace-clock.h
b/arch/powerpc/include/asm/trace-clock.h
index 9aee572..b0b4e21 100644
--- a/arch/powerpc/include/asm/trace-clock.h
+++ b/arch/powerpc/include/asm/trace-clock.h
@@ -11,7 +11,7 @@

 #include <linux/timex.h>
 #include <linux/time.h>
-#include <asm/processor.h>
+#include <asm/time.h>

 static inline u32 trace_clock_read32(void)
 {


This fixes the compiles error on powerpc.

Thanks,
-Srikanth

-- 


On Wed, Apr 29, 2009 at 6:28 PM, srikanth krishnakar
<skrishnakar at gmail.com>wrote:

> Hi Mathieu,
>
> On Wed, Apr 29, 2009 at 6:12 PM, Mathieu Desnoyers <
> compudj at krystal.dyndns.org> wrote:
>
>> * srikanth krishnakar (skrishnakar at gmail.com) wrote:
>> > Hi Mathieu,
>> >
>> > Testing with latest LTTng verison 2.6.29-lttng-0.122  for kernel
>> > linux-2.6.29 gives following compile error for PowerPC architecture :
>> >
>> > ---------------------------
>> > LTTng : 2.6.29-lttng-0.122
>> > Kernel : Linux-2.6.29
>> > Arch: PPC_32
>> > Toolchain: ppc_440
>> > ---------------------------
>> >
>> > In file included from include/linux/trace-clock.h:13,
>> >                  from include/linux/ltt-tracer.h:22,
>> >                  from kernel/marker.c:29:
>> > linux-2.6.29-lttng/arch/powerpc/include/asm/trace-clock.h: In function
>> > ‘trace_clock_read32’:
>> > linux-2.6.29-lttng/arch/powerpc/include/asm/trace-clock.h:18: error:
>> > implicit declaration of function ‘get_tbl’
>> > linux-2.6.29-lttng/arch/powerpc/include/asm/trace-clock.h: In function
>> > ‘trace_clock_read64’:
>> > linux-2.6.29-lttng/arch/powerpc/include/asm/trace-clock.h:23: error:
>> > implicit declaration of function ‘get_tb’
>> > make[1]: *** [kernel/marker.o] Error 1
>> > make: *** [kernel] Error 2
>> >
>> > This error is first seen in :
>> >
>> > *2.6.29-rc8-lttng-0.112
>> >
>> > Continues till 2.6.29-lttng-0.122
>> > *
>> >
>> > As per your earlier request I am attaching the default .config used
>> while
>> > compilation.
>> >
>> >
>> > Can you please submit a fix for this error ???
>> >
>>
>> Yes, I think I'll need your full .config.
>>
>> And please try 2.6.29.1-lttng-0.124, just to be sure. I remember doing a
>> fix in this area not so long ago, but looking at my current powerpc
>> trace-clock.h there seems to be no obvious change since lttng 0.112.
>
>
> For LTTng 2.6.29-lttng-0.124 I see the same errors as shown below:
>
> In file included from include/linux/trace-clock.h:13,
>                  from include/linux/ltt-tracer.h:22,
>                  from kernel/marker.c:29:
> linux-2.6-lttng/arch/powerpc/include/asm/trace-clock.h: In function
> ‘trace_clock_read32’:
> linux-2.6-lttng/arch/powerpc/include/asm/trace-clock.h:18: error: implicit
> declaration of function ‘get_tbl’
> linux-2.6-lttng/arch/powerpc/include/asm/trace-clock.h: In function
> ‘trace_clock_read64’:
> linux-2.6-lttng/arch/powerpc/include/asm/trace-clock.h:23: error: implicit
> declaration of function ‘get_tb’
> make[1]: *** [kernel/marker.o] Error 1
> make: *** [kernel] Error 2
> [root at srikant linux-2.6-lttng]#
>
> Seems still the error exists.
>
> -Srikanth
>
>>
>>
>> Mathieu
>>
>> > Regards
>> > Srikanth Krishnakar
>> > **********************
>>
>>
>> > _______________________________________________
>> > ltt-dev mailing list
>> > ltt-dev at lists.casi.polymtl.ca
>> > http://lists.casi.polymtl.ca/cgi-bin/mailman/listinfo/ltt-dev
>>
>>
>> --
>> Mathieu Desnoyers
>> OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE
>> 9A68
>>
>
>
>
> --
> "The Good You Do, The Best You GET"
>
> Regards
> Srikanth Krishnakar
> **********************
>



-- 
"The Good You Do, The Best You GET"

Regards
Srikanth Krishnakar
**********************
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.casi.polymtl.ca/pipermail/lttng-dev/attachments/20090429/06fb55aa/attachment-0003.htm>